Skip to content

[HOLD for payment 2025-02-05] Fix Changed File ESLint for #11685 (Follow Up) #55658

Description

@srikarparsi

In this PR, the Changed File ESLint is failing because of Namespace Imports. This follow up issue is to fix the ESLint errors from the above PR.

  • LHNOptionsList
  • OptionRowLHNData
  • OptionListContextProvider
  • ParentNavigationSubtitle
  • DebugUtils
  • Task
  • BaseReportActionContextMenu
  • ThreadDivider
  • withReportAndPrivateNotesOrNotFound
  • IOURequestStepAmount
  • IOURequestStepScan
  • IOURequestStepScan
  • LHNItemsPresence
  • SidebarOrderTest

Activity

  1. self-assigned this
    on Jan 23, 2025
  2. changed the title [-]Fix Changed File ESLint for $11685 (Follow Up)[/-] [+]Fix Changed File ESLint for #11685 (Follow Up)[/+] on Jan 23, 2025
  3. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  4. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 29, 2025
  5. changed the title [-]Fix Changed File ESLint for #11685 (Follow Up)[/-] [+][HOLD for payment 2025-02-05] Fix Changed File ESLint for #11685 (Follow Up)[/+] on Jan 29, 2025
  6. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-05. 🎊

  8. melvin-bot commented on Feb 5, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  9. melvin-bot commented on Feb 7, 2025

    @melvin-bot

    @srikarparsi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. melvin-bot commented on Feb 11, 2025

    @melvin-bot

    @srikarparsi Still overdue 6 days?! Let's take care of this!

  11. melvin-bot commented on Feb 13, 2025

    @melvin-bot

    @srikarparsi Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  12. melvin-bot commented on Feb 17, 2025

    @melvin-bot

    @srikarparsi 12 days overdue. Walking. Toward. The. Light...

  13. melvin-bot commented on Feb 20, 2025

    @melvin-bot

    This issue has not been updated in over 14 days. @srikarparsi eroding to Weekly issue.

  14. srikarparsi commented on Mar 1, 2025

    @srikarparsi
    ContributorAuthor

    This fix has been deployed to production and was internal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions