Repository navigation
[Due for payment 2025-04-03] [MEDIUM] Use Mobile-Expensify staging branch for NewDot staging builds #55403
Description
Problem
Every staging E/App build uses Mobile-Expensify main. This means that the following scenario is possible (and has caused fires 🔥!):
- Staging QA is near completion in E/App
- A pull request is merged in Mobile-Expensify that breaks something in HybridApp
- An unrelated E/App PR is CP’d to staging. When this happens, the PR from the previous step is included in the new staging build
- Because QA was already near completion, we ship the checklist without noticing that the PR from step 2 broke something. Now production is broken 💥
Solution
- Create staging and production branches in Mobile-Expensify (following the same branch protections as E/App
- Update the staging and production branches in Mobile-Expensify at the same cadences as NewDot. In other words, when we close the checklist and do a production deploy, main becomes staging and staging becomes production.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021882464639041983694
- Upwork Job ID: 1882464639041983694
- Last Price Increase: 2025-01-23
Issue Owner
Current Issue Owner: @ChristinadobrzynMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to @Christinadobrzyn (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.melvin-bot commentedon Jan 17, 2025
mountiny commentedon Jan 17, 2025
@Expensify/mobile-deployers Curious for your feedback
melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to Design team member for new feature review - @shawnborton (
NewFeature)luacmartins commentedon Jan 17, 2025
That makes sense to me
90 remaining items
melvin-bot commentedon Mar 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 27, 2025
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Christinadobrzyn commentedon Mar 27, 2025
Just a heads up that I'm going to be ooo March 27th - April 6th. Back on the 7th.
I'm going to assign a teammate to pay this out.
We're waiting on the regression test and payment summary here. #55403 (comment)
melvin-bot commentedon Mar 27, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Christinadobrzyn commentedon Mar 27, 2025
Wait sorry I just noticed this is closed, @eh2077 are we not paying you out in this? cc @roryabraham does this need payment?
eh2077 commentedon Mar 27, 2025
@Christinadobrzyn No payment needed here as it doesn't need c+ work, thanks!
Christinadobrzyn commentedon Mar 27, 2025
Ah okay! Thank you! closing again.