[HOLD for payment 2025-02-04] [$75] Expense - Cancelled spelling is different & full stop in system message is shown

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: V9.0.85-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

Go to https://staging.new.expensify.com/home
Open a workspace chat
Create a expense
Open the expense
Select pay elsewhere from drop-down
Pay the expense
Tap header - cancel the payment
Note the title above amount field and system message below the expense

Expected Result:

The system message should spell canceled with one l, and should not have a full stop.

Copy: "canceled the %amount% payment"

Actual Result:

The system message uses the (arguably superior) spelling of cancelled and includes a full stop.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6714051_1736867814161.Screenrecorder-2025-01-14-20-35-45-983_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021879342639421320206
Upwork Job ID: 1879342639421320206
Last Price Increase: 2025-01-15

Issue Owner

Current Issue Owner: @trjExpensify

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format.

🚨 Edited by proposal-police: This proposal was edited at 2025-01-16 18:04:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cancelled spelling is different & full stop in system message is shown

What is the root cause of that problem?

This is a translation issue. The issue uses 'cancelled' and includes a period at the end.

App/src/languages/en.ts

Line 973 in ae97b24

    
           adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}cancelled the ${amount} payment.`,

What changes do you think we should make in order to solve the problem?

To fix this issue, we must update cancelled to canceled to ensure consistency with other instances and remove the period at the end. It should look something like this

App/src/languages/en.ts

Line 973 in ae97b24

    
           adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}cancelled the ${amount} payment.`,

adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}canceled the ${amount} payment`,

And we should remove the period at the end for ‘es’ as well.

App/src/languages/es.ts

Line 969 in 3db57e8

    
           adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}canceló el pago de ${amount}.`,

To make it consistent, we should remove the period at the end for violationDismissal.rter, iou.adminCanceledRequest, etc. We should remove the period at the end in both en and es

Note: My proposal differs from the previous proposal because the previous proposal only fixes one case, but we have two cases: the difference in canceled and the dot at the end

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a UI bug and does not require testing.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@jamesdeanexpensify

@jamesdeanexpensify Jaaaaaames. Can you confirm here before I move it on? Is it:

Canceled should only use one l because America is so great, yada yada yada.
The system message should not have a full stop. (Btw, a full stop is what we call a period.. just to avoid you having to use google translate for that mate 😏 😛).

Here's a still from the OP for ease:

Right on both (fortunately or unfortunately lol)

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

lolol. Updated the OP. Dropping the price for this small copy update.

Job added to Upwork: https://www.upwork.com/jobs/~021879342639421320206

@mollfpr

@mollfpr @trjExpensify @mollfpr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: No offending PR.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: Not a critical issue.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

I don't think we need to create a new test case, probably update this test https://expensify.testrail.io/index.php?/cases/view/1179977 with correct copy.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

@mollfpr

Yeah, agreed we don't need a new test for this.

Payment summary as follows:

$75 to @Themoonalsofall for the PR
$75 to @mollfpr for the C+ review

@Themoonalsofall can you give me your Upwork profile, please? Thanks!

@mollfpr

Payment Summary

Upwork Job

Reviewer: @mollfpr owed $250 via NewDot
ROLE: @Themoonalsofall paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1879342639421320206/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@trjExpensify My upwork: https://www.upwork.com/freelancers/~015dd9c33e65de95d2

Thanks, sent you an offer!

Paid, closing!

@mollfpr

$250 approved for @mollfpr

Navigation Menu

Repository navigation

[HOLD for payment 2025-02-04] [$75] Expense - Cancelled spelling is different & full stop in system message is shown #55218

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

55 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Payment Summary

BugZero Checklist (@trjExpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2025-02-04] [$75] Expense - Cancelled spelling is different & full stop in system message is shown #55218

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 14, 2025

github-actions commented on Jan 14, 2025

huult commented on Jan 14, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

trjExpensify commented on Jan 15, 2025

jamesdeanexpensify commented on Jan 15, 2025

melvin-bot commented on Jan 15, 2025

trjExpensify commented on Jan 15, 2025

melvin-bot commented on Jan 15, 2025

55 remaining items

melvin-bot commented on Jan 28, 2025

mollfpr commented on Feb 3, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

trjExpensify commented on Feb 3, 2025

melvin-bot commented on Feb 4, 2025

Payment Summary

BugZero Checklist (@trjExpensify)

trjExpensify commented on Feb 5, 2025

trjExpensify commented on Feb 5, 2025

garrettmknight commented on Feb 11, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions