Skip to content

[SOBIT - WAITING ON CHECKLIST] [$250] Workspace - Not found page is displayed only on LHN when deleting a workspace from OD #55122

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5441953
Email or phone of affected tester (no customers): expensify416+da2@gmail.com
Issue reported by: Applause - Internal Team
Component: Workspace Settings

Action Performed:

  1. Open one account in new dot and old dot
  2. In ND, create a workspace and navigate to workspace profile page (don't close this page, it should be remained opened)
  3. In OD, navigate to Settings > Workspaces > Group and delete the workspace

Expected Result:

In ND, full screen not found page should be displayed immediately.

Actual Result:

Not found page is only displayed on LHN for a while, then moves to full page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6711715_1736592941115.Screen_Recording_2025-01-11_at_1.45.22_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021878269152575163326
  • Upwork Job ID: 1878269152575163326
  • Last Price Increase: 2025-02-10
  • Automatic offers:
    • nkdengineer | Contributor | 105780491
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 11, 2025
  2. melvin-bot commented on Jan 11, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. jliexpensify commented on Jan 12, 2025

    @jliexpensify
    Contributor

    Able to repro:

    image

    I think this is a #quality bug but it's low priority.

    Changed the results to:

    Expected Result:

    In ND, full screen not found page should be displayed immediately.

    Actual Result:

    Not found page is only displayed on LHN for a while, then moves to full page.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 12, 2025
  5. melvin-bot commented on Jan 12, 2025

    @melvin-bot
  6. changed the title [-]Workspace - Not found page is displayed only on LHN when deleting a workspace from OD[/-] [+][$250] Workspace - Not found page is displayed only on LHN when deleting a workspace from OD[/+] on Jan 12, 2025
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 12, 2025
  8. melvin-bot commented on Jan 12, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  9. changed the title [-][$250] Workspace - Not found page is displayed only on LHN when deleting a workspace from OD[/-] [+][$125] Workspace - Not found page is displayed only on LHN when deleting a workspace from OD[/+] on Jan 12, 2025
  10. melvin-bot commented on Jan 12, 2025

    @melvin-bot

    Upwork job price has been updated to $125

  11. 48 remaining items

  12. jliexpensify commented on Feb 17, 2025

    @jliexpensify
    Contributor

    Bumping @sobitneupane for the checklist!

    Payment Summary

    Upwork job

  13. nkdengineer commented on Feb 17, 2025

    @nkdengineer
    Contributor

    @jliexpensify I applied to the Upwork job

  14. jliexpensify commented on Feb 18, 2025

    @jliexpensify
    Contributor

    @sobitneupane bumping you for the checklist!

  15. jliexpensify commented on Feb 19, 2025

    @jliexpensify
    Contributor

    @nkdengineer something weird happened with the offer, I had to withdraw the $125 one. Can you accept the $250 one?

    @sobitneupane:

    Image

  16. nkdengineer commented on Feb 19, 2025

    @nkdengineer
    Contributor

    @jliexpensify I accepted the offer 🙏

  17. jliexpensify commented on Feb 19, 2025

    @jliexpensify
    Contributor

    Paid and job closed.

  18. changed the title [-][Due for payment 2025-02-18] [$250] Workspace - Not found page is displayed only on LHN when deleting a workspace from OD[/-] [+][SOBIT - WAITING ON CHECKLIST] [$250] Workspace - Not found page is displayed only on LHN when deleting a workspace from OD[/+] on Feb 19, 2025
  19. sobitneupane commented on Feb 19, 2025

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Create a new workspace in ND and and navigate to the workspace profile page.
    2. Login to the same account in OD and delete the workspace
    3. Verify that fullscreen Not Found page is displayed in ND.

    Do we agree 👍 or 👎

  20. sobitneupane commented on Feb 19, 2025

    @sobitneupane
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: fix: deleted workspace with invoices is accessible by url #49509 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  21. jliexpensify commented on Feb 20, 2025

    @jliexpensify
    Contributor
  22. garrettmknight commented on Mar 24, 2025

    @garrettmknight
    Contributor

    $250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions