Skip to content

[$250] [Due for payment 2025-02-10] Not prompting to authenticate with the bank if the credentials have expired when assigning cards from workspace member profile. #55104

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): convert

Action Performed:

Precondition: Credential status in expired condition for assigning cards

  1. Navigate to members section of a Workspace where company cards are enabled and added
  2. Select a member and click + new card
  3. Select Card and click Next

Expected Result:

Authentication page displayed to assign the card

Actual Result:

Authentication page not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
2025-01-10_14-11-29.1.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021887999200239734379
  • Upwork Job ID: 1887999200239734379
  • Last Price Increase: 2025-02-07
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 10, 2025
  2. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Jan 10, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. allgandalf commented on Jan 11, 2025

    @allgandalf
    Contributor

    Please assign me here, this seems to be similar to the PR we worked on @waterim

  5. moved this from In Progress to Todo in [#whatsnext] #converton Jan 12, 2025
  6. 72 remaining items

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 7, 2025
  8. melvin-bot commented on Feb 7, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  9. abdullraafay commented on Feb 8, 2025

    @abdullraafay

    I Implement a conditional check that triggers a secure re-authentication prompt when expired bank credentials are detected during card assignment. This will fix the issue

    Contributor details
    Your Expensify account email: ar61087045@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~017ba58e2734b48e28

  10. melvin-bot commented on Feb 8, 2025

    @melvin-bot

    📣 @abdulrafay155! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  11. abdullraafay commented on Feb 8, 2025

    @abdullraafay

    Contributor details
    Your Expensify account email: ar61087045@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~017ba58e2734b48e28

  12. melvin-bot commented on Feb 8, 2025

    @melvin-bot

    ⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

  13. allgandalf commented on Feb 10, 2025

    @allgandalf
    Contributor

    Payment today 💃

  14. VictoriaExpensify commented on Feb 10, 2025

    @VictoriaExpensify
    Contributor

    Is @abdulrafay155 due any payment on this? They are not assigned to the issue and it's not evident that they have contributed to it, but I see they have been prompted to add their Upwork details.

    @mountiny @allgandalf can you shed any light here?

  15. VictoriaExpensify commented on Feb 10, 2025

    @VictoriaExpensify
    Contributor

    Payment Summary:

    Reviewer: @allgandalf paid $250 via Upwork (offer)
    Upwork job

  16. allgandalf commented on Feb 10, 2025

    @allgandalf
    Contributor

    @VictoriaExpensify we're good to close this issue, @abdulrafay155 didn't contribute to this issue, but we do want to see @abdulrafay155 around posting proposals for other help wanted issues 😄

  17. VictoriaExpensify commented on Feb 10, 2025

    @VictoriaExpensify
    Contributor

    Awesome, thanks for confirming @allgandalf. Look forward to your future proposals @abdulrafay155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions