Skip to content

[HOLD for payment 2025-02-07] [HOLD for payment 2025-02-05] We aren't showing broken connection error on the feed when the connection is broken #55103

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): convert

Action Performed:

  1. User added the company card and break to revoke authorization for added card feed

Expected Result:

Broken connection error on the card feed page

Actual Result:

No error message displayed in feed page. Only thing that indicates it is not working properly is, no cards left to assign message displayed (when there is one left)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image - 2025-01-10T140540 222 (1)

image - 2025-01-10T140551 919 (1)

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 10, 2025
  2. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Jan 10, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. allgandalf commented on Jan 11, 2025

    @allgandalf
    Contributor

    please assign me here, callstack will implement this one most probably

  5. self-assigned this
    on Jan 12, 2025
  6. VickyStash commented on Jan 13, 2025

    @VickyStash
    Contributor

    Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

  7. 22 remaining items

  8. changed the title [-][HOLD for payment 2025-02-05] We aren't showing broken connection error on the feed when the connection is broken[/-] [+][HOLD for payment 2025-02-07] [HOLD for payment 2025-02-05] We aren't showing broken connection error on the feed when the connection is broken[/+] on Jan 31, 2025
  9. melvin-bot commented on Jan 31, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-07. 🎊

    For reference, here are some details about the assignees on this issue:

    • @VickyStash does not require payment (Contractor)
    • @getusha requires payment through NewDot Manual Requests
  10. melvin-bot commented on Jan 31, 2025

    @melvin-bot

    @getusha @alexpensify @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on Feb 7, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @VickyStash is from an agency-contributor and not due payment
    • Reviewer: @getusha owed $250 via NewDot

    BugZero Checklist (@alexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. melvin-bot commented on Feb 7, 2025

    @melvin-bot

    @alexpensify, @VickyStash, @mountiny, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. alexpensify commented on Feb 8, 2025

    @alexpensify
    Contributor

    Contributor: @VickyStash agency-contributor and not due payment
    Contributor+: @getusha owed $250 via NewDot

    Please submit a request in Chat. Thanks!

  14. garrettmknight commented on Mar 11, 2025

    @garrettmknight
    Contributor

    $250 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions