[Awaiting checklist] [$250] When adding a direct card feed, we link you out to the bank to authenticate while offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): ts_external_expensify_convert

Action Performed:

1. Enable company cards in workspace settings
2. Click Add cards and select any bank
3. Select Direct and go offline
4. Click Next

---

1. When trying to assign card on direct feed specifically
2. The Assign card option is allowed when offline

Expected Result:

Authenticate via bank mode not displayed when User is in offline

Next button and the Assign card button in modal for direct feeds should be disabled when offline.

Using PAttern B is hard here as the connection expires often soon so there is high chance the call could fail

Actual Result:

Authenticate via bank mode displayed. Same result observed when you try to assign cards while offline and need to authenticate first.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2025-01-10_12-01-43.mp4

2025-01-10_12-18-15.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021878570494468361150
• Upwork Job ID: 1878570494468361150
• Last Price Increase: 2025-02-19
• Automatic offers:
• huult | Contributor | 105707373

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Shahidullah-Muffakir]

Edited by proposal-police: This proposal was edited at 2025-01-13 00:32:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. The Next button in the feed type selection is not disabled when the user is offline.
2. The Assign Card button is not disabled when the user is offline.

What is the root cause of that problem?

When the user is offline:

1. We did not disable the Next button in the feed type selection at the following locations:

   • App/src/pages/workspace/companyCards/addNew/SelectFeedType.tsx

     Lines 91 to 92 in 15f0b50

     	showConfirmButton
     	confirmButtonText={translate('common.next')}

   • App/src/components/SelectionList/BaseSelectionList.tsx

     Lines 862 to 864 in 15f0b50

     	<Button
     	success={!shouldUseDefaultTheme}
     	large

2. We did not disable the Assign Card button at the following location:

   • App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

     Line 152 in 5ffe883

     isDisabledAssignCardButton={!selectedFeedData || !!selectedFeedData?.errors}

What changes do you think we should make in order to solve the problem?

1. Disable the Assign Card button when the user is offline:

   • Add the || isOffline condition to the existing check at this location:

     isDisabledAssignCardButton={!selectedFeedData || !!selectedFeedData?.errors || isOffline}

2. Disable the Next button in the feed type selection:

   1. Add a new prop to BaseSelectionListProps called isConfirmButtonDisabled to convey the purpose clearly.
   2. Pass isConfirmButtonDisabled={isOffline} at this location:

      • App/src/pages/workspace/companyCards/addNew/SelectFeedType.tsx

        Lines 91 to 93 in 15f0b50

        	showConfirmButton
        	confirmButtonText={translate('common.next')}
        	onConfirm={submit}

   3. Update the button in BaseSelectionList to use the new prop by setting:

      disabled={isConfirmButtonDisabled}

`

3. we may want to disable this Assign card button as well in WorkspaceCompanyCardsListHeaderButtons:

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

Lines 85 to 88 in c30c298

	{!!shouldShowAssignCardButton && (
	<Button
	success
	isDisabled={!currentFeedData || !!currentFeedData?.pending || !!currentFeedData?.errors}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

In the feed selection type, instead of disabling the next button, show the FullPageOfflineBlockingView by changing the following code in SelectFeedType.tsx as:

return (
    <ScreenWrapper
        testID={SelectFeedType.displayName}
        includeSafeAreaPaddingBottom={false}
        shouldEnablePickerAvoiding={false}
        shouldEnableMaxHeight
    >
        <HeaderWithBackButton
            title={translate('workspace.companyCards.addCards')}
            onBackButtonPress={handleBackButtonPress}
        />
        <FullPageOfflineBlockingView>

[allgandalf]

please assign me here, Probably not open for proposals , maybe CallStack would work on this as part of project , right @mountiny ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021878570494468361150