Skip to content

[HOLD for payment 2025-02-04] [$125] iOS - Extra spacing before field label #54971

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.82-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+010108kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Money Requests

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to workspace chat.
  3. Create an expense with merchant and description.
  4. Go to transaction thread.
  5. Tap Description or Manual or Date.
  6. Note that there is spacing before field label.
  7. Go to workspace settings > Workspace profile.
  8. Tap Workspace name.
  9. Note that there is spacing before field label.

Expected Result:

There should be no spacing before field label.

Actual Result:

There is spacing before field label.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6709222_1736352878571.ScreenRecording_01-09-2025_00-13-56_1.mp4

Bug6709222_1736355059420!Screenshot_2025-01-09_005047

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021877309187559460244
  • Upwork Job ID: 1877309187559460244
  • Last Price Increase: 2025-01-09
  • Automatic offers:
    • shubham1206agra | Contributor | 105665977
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 8, 2025
  2. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. jliexpensify commented on Jan 8, 2025

    @jliexpensify
    Contributor

    This looks like a UI issue, not an actual deploy blocker. Will defer to Puneet though.

  7. 50 remaining items

  8. jliexpensify commented on Feb 4, 2025

    @jliexpensify
    Contributor

    Thanks! Paid and job closed.

  9. mallenexpensify commented on Mar 13, 2025

    @mallenexpensify
    Contributor

    @shubham1206agra , @blazejkustra did code from @linhvovan29546 get used in the fix? If so, they might be due compensation. Please share quick details so we can settle this.

  10. shubham1206agra commented on Mar 14, 2025

    @shubham1206agra
    Contributor

    @mallenexpensify The exact code proposed by @linhvovan29546 was wrong. And this was 2 line change, so I am gonna say no here.

  11. linhvovan29546 commented on Mar 14, 2025

    @linhvovan29546
    Contributor

    Hmm... The idea for the solution is to use fontSize with interpolate instead of scale. The merged PR is slightly different from my proposal regarding the variable, but overall, I think it's similar. Correct me if I'm wrong.

  12. shubham1206agra commented on Mar 14, 2025

    @shubham1206agra
    Contributor

    There was difference in 2 places. And the PR is not that big.

  13. jliexpensify commented on Mar 17, 2025

    @jliexpensify
    Contributor

    So can we close this GH? cc @mallenexpensify

  14. melvin-bot commented on Mar 17, 2025

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. mallenexpensify commented on Mar 18, 2025

    @mallenexpensify
    Contributor

    Yeah, going to close. Thanks y'all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions