[HOLD for payment 2025-01-18] [$250] Category receipt required amount is displaying the wrong default value.

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.81-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @VictoriaExpensify
Slack conversation (hyperlinked to channel name): #expense

Action Performed:

1. Go to new.expensify.com
2. Create a workspace
3. Go to More features > Enable Rules > Upgrade
4. Go to Rules
5. Observe the receipt required amount is set to £25.00
6. Go to Categories
7. Click on a category value in the table to open the settings in the RHP
8. Observe the "require receipts over" default is set to £2000.00
9. Create and submit a manual expense on the workspace for £29.00 without a receipt
10. Observe the violation for receipts being required for expenses over £25.00

Expected Result:

The default in step 8 should be displayed as £25.00 to match the receipt required amount set on the workspace.

Actual Result:

The default in step 8 is displayed as £2000.00.

Note: It seems like we're displaying the max expense amount value instead, perhaps here.

Workaround:

Yes, the limit is correctly set to the workspace default on the backend, it's a display issue showing it as the wrong value in the category settings page.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876762664887061908
• Upwork Job ID: 1876762664887061908
• Last Price Increase: 2025-01-07
• Automatic offers:
• shubham1206agra | Reviewer | 105609818
• truph01 | Contributor | 105609822

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021876762664887061908

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The default in step 8 is displayed as £2000.00.

What is the root cause of that problem?

• In here:

App/src/libs/CategoryUtils.ts

Line 39 in f1cede9

const maxExpenseAmountToDisplay = policy?.maxExpenseAmount === CONST.DISABLED_MAX_EXPENSE_VALUE ? 0 : policy?.maxExpenseAmount;

we are using policy?.maxExpenseAmount.

What changes do you think we should make in order to solve the problem?

• We should use policy?.maxExpenseAmountNoReceipt instead:

    const maxExpenseAmountToDisplay = policy?.maxExpenseAmountNoReceipt === CONST.DISABLED_MAX_EXPENSE_VALUE ? 0 : policy?.maxExpenseAmountNoReceipt;

• We should fix:

App/src/pages/workspace/categories/CategoryRequireReceiptsOverPage.tsx

Line 48 in f1cede9

const maxExpenseAmountToDisplay = policy?.maxExpenseAmount === CONST.DISABLED_MAX_EXPENSE_VALUE ? 0 : policy?.maxExpenseAmount;

as well.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

[shubham1206agra]

@truph01's proposal looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.