Repository navigation
[HOLD for payment 2025-02-04] [$250] PR - No error message displayed for greater than 15 mb jpg file #54700
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #53902
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sonoma 14.4.1
App Component: Other
Action Performed:
- Open the New Expensify Desktop app
- Click on FAB > Submit expense
- Enter an amount, click on 'Next'
- Choose any recipient
- Click on three dots at top right corner in expense creation screen
- Click 'Add receipt'
- Select a receipt equal or greater than 10mb.
Expected Result:
Verify that 'Attachment is too large - Attachment size is larger than 10 MB limit' is displayed
Actual Result:
Able to upload the file with no issues
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6704689_1735685408972.PR_53902_Desktop.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021874862385024395150
- Upwork Job ID: 1874862385024395150
- Last Price Increase: 2025-01-16
- Automatic offers:
- nkdengineer | Contributor | 105776417
Issue Owner
Current Issue Owner: @MitchExpensifyMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]PR 53902 - No error message displayed for greater than 15 mb jpg file[/-][+]PR - No error message displayed for greater than 15 mb jpg file[/+]mitarachim commentedon Jan 1, 2025
@Themoonalsofall Okay thank you for clarify, so should be truly receipt in .jpg or .png ?
mitarachim commentedon Jan 1, 2025
@Themoonalsofall already ask tester to re-test.
seems tester not available at the moment , i also try in my side and can see the restriction while using PDF larger than 10 MB
Screen.Recording.2025-01-01.at.3.02.08.PM.mp4
[-]PR - No error message displayed for greater than 15 mb jpg file[/-][+][$250] PR - No error message displayed for greater than 15 mb jpg file[/+]melvin-bot commentedon Jan 2, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021874862385024395150
melvin-bot commentedon Jan 2, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)48 remaining items
MitchExpensify commentedon Jan 30, 2025
Payment summary:
Reminder on the BZ steps above, @jayeshmangwani - Thank you!
jayeshmangwani commentedon Feb 3, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The issue initially arose because we had the wrong QA steps for this PR: Fix unable to upload a receipt size larger than 15mb #53902
Comment from the contributor who raised the above PR: [HOLD for payment 2025-02-04] [$250] PR - No error message displayed for greater than 15 mb jpg file #54700 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Do we agree 👍 or 👎
luacmartins commentedon Feb 3, 2025
I don't think we need a specific one for this issue. We already test receipt uploads, which should be enough.
melvin-bot commentedon Feb 6, 2025
@luacmartins, @jayeshmangwani, @MitchExpensify, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
jayeshmangwani commentedon Feb 7, 2025
@MitchExpensify, issue is ready to be paid.
melvin-bot commentedon Feb 10, 2025
@luacmartins, @jayeshmangwani, @MitchExpensify, @nkdengineer 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
luacmartins commentedon Feb 10, 2025
Bump for payment @MitchExpensify
MitchExpensify commentedon Feb 11, 2025
Paid @nkdengineer, @jayeshmangwani needs payment in New Expensify as a next step - Closing
garrettmknight commentedon Feb 11, 2025
$250 approved for @jayeshmangwani