Repository navigation
[HOLD for payment 2025-02-04] [HOLD for payment 2025-01-28] [$250] Web - Trip - Payment with Expensify button shown next to submit button on Open trip report #54538
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #52823
Email or phone of affected tester (no customers): applausetester+0948501@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Chat Report View
Action Performed:
Precondition:
- Create a trip with steps from this PR [vip-travel] Create Trip Details Screen #52823
- Go to staging.new.expensify.com
- Go to trip room.
- Click on the expense preview.
Expected Result:
There should only be a Submit button at the top of the report page.
Actual Result:
There are two buttons - "Pay with Expensify" and "Submit"
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6701759_1735043098180.bandicam_2024-12-24_20-22-00-193.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021876334627155535758
- Upwork Job ID: 1876334627155535758
- Last Price Increase: 2025-01-06
- Automatic offers:
- shubham1206agra | Contributor | 105583255
Metadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Dec 24, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.sakluger commentedon Dec 24, 2024
The actual bug here is that the expense report shows a
Pay with expensifybutton at all. The report is still open, so it shouldn't have a Pay option, in fact, I can't think of any scenario where we would show both a submit and pay button at the same time.@rojiphil @jacobkim9881 do you think this is related to #53226 at all?
[-]Web - Trip - No gap between payment button and submit button in trip report[/-][+]Web - Trip - Payment with Expensify button shown next to submit button on Open trip report[/+]jacobkim9881 commentedon Dec 27, 2024
@sakluger I not sure if it is related. I have tried
Action Performedbut I couldn't because I can't enable travel. I can test if I get a company email.melvin-bot commentedon Dec 30, 2024
@sakluger Huh... This is 4 days overdue. Who can take care of this?
sakluger commentedon Dec 30, 2024
@jacobkim9881 we can't get you a company email, but I can add your testing email to the travel beta. What email are you using to test?
sakluger commentedon Dec 30, 2024
Actually, it looks like you would have to actually book travel to test, which would require you to spend real money. I'm going to ask around internally first.
jacobkim9881 commentedon Dec 30, 2024
I understood. I will wait for internal team.
jacobkim9881 commentedon Dec 30, 2024
I know I should actually book travel to test but in case my email is like below:
jacobkim9881 commentedon Dec 30, 2024
56 remaining items
[-][HOLD for payment 2025-01-28] [$250] Web - Trip - Payment with Expensify button shown next to submit button on Open trip report[/-][+][HOLD for payment 2025-02-04] [HOLD for payment 2025-01-28] [$250] Web - Trip - Payment with Expensify button shown next to submit button on Open trip report[/+]melvin-bot commentedon Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 28, 2025
@shubham1206agra @sakluger @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
sakluger commentedon Feb 5, 2025
Hey @shubham1206agra - please complete the BZ checklist so that I can complete payment. Thanks!
shubham1206agra commentedon Feb 5, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/41859/files#r1943324139
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Submitbutton is visibleDo we agree 👍 or 👎
sakluger commentedon Feb 5, 2025
Thanks!
Summarizing payment on this issue:
Contributor: @blazejkustra - No payment needed
Contributor+: @shubham1206agra $250, paid via Upwork