[HOLD for payment 2025-01-13] Per diem - Amount cannot be cleared when there is negative sign

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.78-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+909608@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace has per diem rates.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Per diem
3. Click on any rate that has negative amount.
4. Click Amount.
5. Try to delete everything in the input.
6. Note that the input cannot be cleared when there is a negative sign.
7. Open another rate that does not have negative amount.
8. Click Amount.
9. Clear the input.
10. Add a negative sign.
11. Note that the input does not accept negative sign when the field is cleared.

Expected Result:

In Step 6, the input should be able to clear when there is a negative sign.
In Step 11, the input should accept negative sign when the field is cleared.

Actual Result:

In Step 6, the input cannot be cleared when there is a negative sign.
In Step 11, the input does not accept negative sign when the field is cleared.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701576_1735004229102.20241224_093110.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Offending PR: #53625

[c3024]

This is known and will be fixed in a follow-up PR. Per diem is under beta. This need not be a deploy blocker.

cc: @shubham1206agra

[Beamanator]

Amazingly quick work, thanks both!!

So @c3024 do you prefer we keep this issue open to track that follow-up fix?