Activity

1. neil-marcellini

   self-assigned this

   on Dec 23, 2024
2. neil-marcellini

   added

   DailyKSv2KSv2

   on Dec 23, 2024
3. ChavdaSachin commented on Dec 23, 2024

   

   ChavdaSachin

   on Dec 23, 2024

   Contributor

   More actions

   Proposal

   Please re-state the problem that we are trying to solve in this issue.

   Refactor

   What is the root cause of that problem?

   NA

   What changes do you think we should make in order to solve the problem?

   Refactor IOU.shareTrackedExpense function.
   Minimize Input fields and cluster input params in sensible sub-objects.

   What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

   No Changes.

   What alternative solutions did you explore? (Optional)

   Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
4. neil-marcellini

   assigned

   ChavdaSachin

   on Dec 23, 2024
5. neil-marcellini

   added

   BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.

   ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor

   on Dec 23, 2024
6. melvin-bot

   changed the title [-]Refactor shareTrackedExpense to use a parameter object[/-] [+][$250] Refactor shareTrackedExpense to use a parameter object[/+] on Dec 23, 2024
7. melvin-bot commented on Dec 23, 2024

   

   melvin-botBot

   on Dec 23, 2024 – with Melvin Bot

   More actions

   Job added to Upwork: https://www.upwork.com/jobs/~021871214955675002445
8. melvin-bot commented on Dec 23, 2024

   

   melvin-botBot

   on Dec 23, 2024 – with Melvin Bot

   More actions

   Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
9. melvin-bot

   assigned

   MitchExpensify

   on Dec 23, 2024
10. melvin-bot

    added

    Help WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

    on Dec 23, 2024
11. melvin-bot

    assigned

    eVoloshchak

    on Dec 23, 2024
12. melvin-bot commented on Dec 23, 2024

    

    melvin-botBot

    on Dec 23, 2024 – with Melvin Bot

    More actions

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)
13. neil-marcellini

    removed

    Help WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

    on Dec 23, 2024
14. melvin-bot commented on Dec 27, 2024

    

    melvin-botBot

    on Dec 27, 2024 – with Melvin Bot

    More actions

    @eVoloshchak, @neil-marcellini, @MitchExpensify, @ChavdaSachin Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
15. 15 remaining items

    Load more

16. ChavdaSachin commented on Jan 30, 2025

    

    ChavdaSachin

    on Jan 30, 2025

    Last edited by ChavdaSachin

    Contributor

    More actions

    @neil-marcellini default IDs are already implemented Here, we are free to close this issue as soon as 7 days regresion period is over for this PR.
17. ChavdaSachin commented on Feb 3, 2025

    

    ChavdaSachin

    on Feb 3, 2025

    Contributor

    More actions

    @neil-marcellini could you please send upwork offers and mark this GH as pending for payment.
    check my previous comment.
18. MitchExpensify commented on Feb 3, 2025

    

    MitchExpensify

    on Feb 3, 2025

    Contributor

    More actions

    @ChavdaSachin It's my role to make sure the Upwork offers are sent. Has the PR hit production yet? The offers should go out automatically once it has
19. ChavdaSachin commented on Feb 4, 2025

    

    ChavdaSachin

    on Feb 4, 2025

    Contributor

    More actions

    Pr did hit production 7 days back
20. MitchExpensify

    removed

    ReviewingHas a PR in reviewHas a PR in review

    on Feb 4, 2025
21. MitchExpensify commented on Feb 4, 2025

    

    MitchExpensify

    on Feb 4, 2025

    Contributor

    More actions

    BugZero Checklist:

    • [Contributor] Classify the bug:

    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎
22. MitchExpensify commented on Feb 4, 2025

    

    MitchExpensify

    on Feb 4, 2025

    Last edited by MitchExpensify

    Contributor

    More actions

    Payment summary:

    • $250 @ChavdaSachin Reviewer
    • $250 @eVoloshchak Reviewer - NewDot
23. MitchExpensify commented on Feb 4, 2025

    

    MitchExpensify

    on Feb 4, 2025

    Contributor

    More actions

    Here is your offer @ChavdaSachin https://www.upwork.com/ab/applicants/1886926850410966330/suggested
24. ChavdaSachin commented on Feb 5, 2025

    

    ChavdaSachin

    on Feb 5, 2025

    Contributor

    More actions

    Accepted
25. MitchExpensify commented on Feb 5, 2025

    

    MitchExpensify

    on Feb 5, 2025

    Contributor

    More actions

    Paid, thanks!

    🎉React with 🎉1Reacted by Chavda Sachin
26. MitchExpensify

    added this to #expensify-bugson Feb 17, 2025
27. eVoloshchak commented on Feb 19, 2025

    

    eVoloshchak

    on Feb 19, 2025

    Contributor

    More actions

    BugZero Checklist in #54466 (comment)

    Classify the bug

    This isn't a bug, but rather a code improvement, not sure if this classification applies here

    The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Same as above, not a bug, there is no offending PR
    No additional discussion in Slack or regression test are needed either

    @eVoloshchak Reviewer - do you require payment on New Dot or Upwork?

    I'll request through NewDot

    👍React with 👍1Reacted by MitchExpensify
28. MitchExpensify

    closed this as completedon Feb 23, 2025
29. github-project-automation

    moved this to Done in #expensify-bugson Feb 23, 2025
30. JmillsExpensify commented on Mar 3, 2025

    

    JmillsExpensify

    on Mar 3, 2025

    Contributor

    More actions

    $250 approved for @eVoloshchak