[Due for payment 2025-02-18] [$250] Border around workspace not matching hovered background in chat log

@dubielzyk-expensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.77-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

Navigate to a workspace chat
Observe the avatar

Expected Result:

Border around workspace avatar matching hovered background in chat log

Actual Result:

Border around workspace avatar not matching hovered background in chat log

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021876300830027484564
Upwork Job ID: 1876300830027484564
Last Price Increase: 2025-01-06
Automatic offers:

shubham1206agra | Contributor | 105581173
nkdengineer | Contributor | 105581179

Issue Owner

Current Issue Owner: @stephanieelliott

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Border around workspace not matching hovered background in chat log

What is the root cause of that problem?

We do not pass styles props to this component

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 210 to 213 in 154a485

    
           <SubscriptAvatar 
        
               mainAvatar={icon} 
        
               secondaryAvatar={secondaryAvatar} 
        
               noMargin

What changes do you think we should make in order to solve the problem?

We can pass the backgroundColor props in the same way we did here

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 249 in 154a485

    
           backgroundColor={hovered && !isFocused ? hoveredBackgroundColor : subscriptAvatarBorderColor}

       backgroundColor={isHovered ? styles.sidebarLinkActive.backgroundColor : theme.sidebar}

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 210 to 213 in 154a485

    
           <SubscriptAvatar 
        
               mainAvatar={icon} 
        
               secondaryAvatar={secondaryAvatar} 
        
               noMargin

Notes: Some minor style changes can discuss in PR phase

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Style change.

What changes do you think we should make in order to solve the problem?

There are two case to be considered here.

Case 1. When Item is being hovered.
Case 2. When Item is not being hovered but is still active(example open three-dot menu for any message and the message retains active state style irrespective of pointer position).

So make following code changes.
First for case 1 -
Pass conditional background style here.

    backgroundColor={isHovered || isActive ? styles.sidebarLinkActive.backgroundColor : theme.sidebar}

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 210 to 213 in 154a485

    
           <SubscriptAvatar 
        
               mainAvatar={icon} 
        
               secondaryAvatar={secondaryAvatar} 
        
               noMargin

And for case 2 -
Introduce a new boolean prop isActive for ReportActionItemSingle component which would hold information about active state of the component.
And pass this condition hovered || isContextMenuActive || isEmojiPickerActive as isActive prop value.

function ReportActionItemSingle({
.
.
isActive = false
.
})

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 70 to 80 in 154a485

    
           function ReportActionItemSingle({ 
        
               action, 
        
               children, 
        
               wrapperStyle, 
        
               showHeader = true, 
        
               shouldShowSubscriptAvatar = false, 
        
               hasBeenFlagged = false, 
        
               report, 
        
               iouReport, 
        
               isHovered = false, 
        
           }: ReportActionItemSingleProps) {

                <ReportActionItemSingle
                  .
                  .
                  isActive={hovered || isContextMenuActive || isEmojiPickerActive}
                  .
                  .
                >

App/src/pages/home/report/PureReportActionItem.tsx

Lines 990 to 1002 in 154a485

    
           <ReportActionItemSingle 
        
               action={action} 
        
               showHeader={draftMessage === undefined} 
        
               wrapperStyle={isWhisper ? styles.pt1 : {}} 
        
               shouldShowSubscriptAvatar={shouldShowSubscriptAvatar} 
        
               report={report} 
        
               iouReport={iouReport} 
        
               isHovered={hovered} 
        
               hasBeenFlagged={ 
        
                   ![CONST.MODERATION.MODERATOR_DECISION_APPROVED, CONST.MODERATION.MODERATOR_DECISION_PENDING].some((item) => item === moderationDecision) && 
        
                   !ReportActionsUtils.isPendingRemove(action) 
        
               } 
        
           >

Test Branch
https://github.com/ChavdaSachin/App/tree/mock-14

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA.

What alternative solutions did you explore? (Optional)

From issue statement it is not quite clear if we want to match the background only in active state or change border color for all the cases.
So in case we want to change it for all the cases pass following prop here..

    backgroundColor={styles.sidebarLinkActive.backgroundColor}

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 210 to 214 in 154a485

    
           <SubscriptAvatar 
        
               mainAvatar={icon} 
        
               secondaryAvatar={secondaryAvatar} 
        
               noMargin 
        
           />

@stephanieelliott

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

@stephanieelliott

@stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

@stephanieelliott

@stephanieelliott 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@stephanieelliott

@stephanieelliott 10 days overdue. I'm getting more depressed than Marvin.

@stephanieelliott

@stephanieelliott this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@stephanieelliott

@stephanieelliott 12 days overdue. Walking. Toward. The. Light...

@nkdengineer

There are some more places where we need to check. But we can discuss this in PR.

Since this issue had no movement for 2 weeks for some reason, I will kickstart this issue by doing the review here.

@nkdengineer's proposal looks good to me.

🎀👀🎀 C+ reviewed

@shubham1206agra

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: border around workspace not matching hovered background #54860

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

@shubham1206agra requires payment automatic offer (Contributor)
@nkdengineer requires payment automatic offer (Contributor)

@shubham1206agra

@shubham1206agra @stephanieelliott @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

@shubham1206agra

Hey @shubham1206agra can you complete the BZ checklist on this one?

@shubham1206agra

Bump on this @shubham1206agra, can you complete the BZ checklist when you get a chance?

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/50424/files#r1964931774
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Test:

Navigate to a workspace chat
Hover the avatar
Observe the avatar
Verify that: Border around workspace avatar matching hovered background in chat log
Create an expense
Go to expense chat
Click header of this chat to return chat report
Verify that: When active border around workspace avatar matching hovered background in chat log

Do we agree 👍 or 👎

@stephanieelliott

@stephanieelliott, @grgia, @shubham1206agra, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

GH for TR case: https://github.com/Expensify/Expensify/issues/473990

@shubham1206agra

Summarizing payment on this issue:

Contributor: @shubham1206agra $250 via ND - please request!
Contributor+: @nkdengineer $250 via Upwork - PAID!

Upwork job is here: https://www.upwork.com/jobs/~021876300830027484564

@shubham1206agra

$250 approved for @shubham1206agra

Navigation Menu

Repository navigation

[Due for payment 2025-02-18] [$250] Border around workspace not matching hovered background in chat log #54387

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

31 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

BugZero Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<SubscriptAvatar
	mainAvatar={icon}
	secondaryAvatar={secondaryAvatar}
	noMargin

	function ReportActionItemSingle({
	action,
	children,
	wrapperStyle,
	showHeader = true,
	shouldShowSubscriptAvatar = false,
	hasBeenFlagged = false,
	report,
	iouReport,
	isHovered = false,
	}: ReportActionItemSingleProps) {

	<ReportActionItemSingle
	action={action}
	showHeader={draftMessage === undefined}
	wrapperStyle={isWhisper ? styles.pt1 : {}}
	shouldShowSubscriptAvatar={shouldShowSubscriptAvatar}
	report={report}
	iouReport={iouReport}
	isHovered={hovered}
	hasBeenFlagged={
	![CONST.MODERATION.MODERATOR_DECISION_APPROVED, CONST.MODERATION.MODERATOR_DECISION_PENDING].some((item) => item === moderationDecision) &&
	!ReportActionsUtils.isPendingRemove(action)
	}
	>

[Due for payment 2025-02-18] [$250] Border around workspace not matching hovered background in chat log #54387

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 19, 2024

nkdengineer commented on Dec 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

ChavdaSachin commented on Dec 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Dec 23, 2024

melvin-bot commented on Dec 25, 2024

melvin-bot commented on Dec 27, 2024

melvin-bot commented on Dec 31, 2024

melvin-bot commented on Jan 2, 2025

melvin-bot commented on Jan 2, 2025

shubham1206agra commented on Jan 6, 2025

31 remaining items

melvin-bot commented on Feb 11, 2025

melvin-bot commented on Feb 11, 2025

stephanieelliott commented on Feb 19, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

stephanieelliott commented on Feb 19, 2025

stephanieelliott commented on Feb 21, 2025

shubham1206agra commented on Feb 21, 2025

BugZero Checklist:

Regression Test Proposal

Test:

melvin-bot commented on Feb 24, 2025

stephanieelliott commented on Feb 24, 2025

stephanieelliott commented on Feb 24, 2025

garrettmknight commented on Apr 22, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions