Repository navigation
[HOLD for payment 2025-02-04] [HOLD for payment 2025-01-24] [$250] Editing a comment: the cursor is jumping to the end of the message when we type in the middle of the text making it impossible to edit the text #54335
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny @quinthar
Slack conversation (hyperlinked to channel name): expensify_bugs
Action Performed:
- Write a message and send it
- Go edit the message
- Move the cursor to the middle of the text
- Start to type
Expected Result:
User able to type where the cursor
Actual Result:
The cursor jumps to the end of the text after a first character
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Screen.Recording.2024-12-18.at.15.15.47.mov
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021869733355861718010
- Upwork Job ID: 1869733355861718010
- Last Price Increase: 2024-12-19
Issue Owner
Current Issue Owner: @stephanieelliottMetadata
Metadata
Labels
Type
Projects
- Status
Activity
MelvinBot commentedon Dec 18, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
melvin-bot commentedon Dec 18, 2024
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.allroundexperts commentedon Dec 18, 2024
Seems related to the grammar extension that they're using.
mountiny commentedon Dec 19, 2024
I do have Grammarly installed
allroundexperts commentedon Dec 19, 2024
Can you try without that?
mountiny commentedon Dec 19, 2024
I dont know how to write without that
mountiny commentedon Dec 19, 2024
I cannot reproduce it now even with it on, so I will keep monitoring if it happens again
m-natarajan commentedon Dec 19, 2024
@mountiny @allroundexperts Able to reproduce this issue in production
Recording.860.mp4
bernhardoj commentedon Dec 19, 2024
I think this is the same as this one
55 remaining items
[-][HOLD for payment 2025-01-24] [$250] Editing a comment: the cursor is jumping to the end of the message when we type in the middle of the text making it impossible to edit the text[/-][+][HOLD for payment 2025-02-04] [HOLD for payment 2025-01-24] [$250] Editing a comment: the cursor is jumping to the end of the message when we type in the middle of the text making it impossible to edit the text[/+]melvin-bot commentedon Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 28, 2025
@allroundexperts @stephanieelliott @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Feb 4, 2025
Payment Summary
Upwork Job
BugZero Checklist (@stephanieelliott)
stephanieelliott commentedon Feb 11, 2025
Summarizing payment on this issue:
bernhardoj commentedon Feb 11, 2025
Requested in ND.
allroundexperts commentedon Feb 11, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: As mentioned in the proposal, this was due to an issue with the focus trap library which is externally managed.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify the edit composer has a green outline
Verify the cursor doesn't go to the end of the text
Do we agree 👍 or 👎
JmillsExpensify commentedon Feb 13, 2025
$250 approved for @bernhardoj
JmillsExpensify commentedon Jun 13, 2025
$250 approved for @allroundexperts