Repository navigation
[HOLD for payment 2025-01-02] [HOLD for payment 2024-12-30] [$500] Onboarding flow is not showing upon first sign in #54322
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation (hyperlinked to channel name):
Action Performed:
Break down in numbered steps
- Sign into a new account
- The onboarding modal is not showing
- Refresh the page
- The modal is shown
Expected Result:
Describe what you think should've happened
The modal should be shown first upon signing the user should not be allowed to skip it
Actual Result:
Describe what actually happened
The user is not presented with the modal
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
2024-12-18_11-11-20.mp4
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021869459467806061602
- Upwork Job ID: 1869459467806061602
- Last Price Increase: 2024-12-18
- Automatic offers:
- nkdengineer | Contributor | 105391259
Activity
[-]Onboarding flow is not showing upon first sign in[/-][+][$250] Onboarding flow is not showing upon first sign in[/+]melvin-bot commentedon Dec 18, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021869459467806061602
melvin-bot commentedon Dec 18, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)melvin-bot commentedon Dec 18, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 18, 2024
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 18, 2024
💬 A slack conversation has been started in #expensify-open-source
52 remaining items
melvin-bot commentedon Dec 23, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 23, 2024
@s77rt @bfitzexpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2024-12-30] [$500] Onboarding flow is not showing upon first sign in[/-][+][HOLD for payment 2025-01-02] [HOLD for payment 2024-12-30] [$500] Onboarding flow is not showing upon first sign in[/+]melvin-bot commentedon Dec 26, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 26, 2024
@s77rt @bfitzexpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
s77rt commentedon Dec 28, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Migrate E/App to use
PlatformStackNavigation#49937 (unknown exact cause but it's very likely that the bug is caused by this PR for switching toPlatformStackNavigation)[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: I don't think this is required here (QA test should pretty much cover this)
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, a test already exists https://expensify.testrail.io/index.php?/cases/view/2990391
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
bfitzexpensify commentedon Dec 31, 2024
Payment summary:
$500 paid to @nkdengineer for contributor work ✅
$500 to be paid to @s77rt for C+ work
JmillsExpensify commentedon Jan 7, 2025
$500 approved for @s77rt