Repository navigation
[HOLD for payment 2025-02-04] [$250] Delete Receipt button is not displayed in merged transaction #53922
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.74-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): tester+mergetests@applausecard.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Action Performed:
Preconditions: A user has a Expensify Card transaction and the receipt to do a merge between the 2.
The account tester+mergetests@applausecard.expensifail.com is setup to test this.
- Log in with tester+mergetests@applausecard.expensifail.com
- Upload the following receipt to the WS chat
- Wait for the Smartscan
- After the transactions have been merged - Navigate to the expense conversation
- Open the receipt
- Click on the 3 dot menu in the preview
Expected Result:
There should be a Delete receipt (or detach) receipt option as there is in OldDot. After the receipt is deleted it should fallback to the eReceipt.
Actual Result:
There's no option to delete (or detach) the receipt like in OldDot.
Workaround:
User can detach the receipt via OldDot.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- [] MacOS: Desktop
Screenshots/Videos
Untitled.video.5.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021867328664713695509
- Upwork Job ID: 1867328664713695509
- Last Price Increase: 2024-12-19
- Automatic offers:
- dominictb | Reviewer | 105403297
Issue Owner
Current Issue Owner: @jliexpensifyMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Dec 11, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.jliexpensify commentedon Dec 12, 2024
@joekaufmanexpensify @robertjchen @luacmartins hello - would this be a new feature? Is there a C+ that's currently working on this?
joekaufmanexpensify commentedon Dec 12, 2024
Not familiar with this flow, but seems like this bug came from an applause issue where we asked them to create regression tests, so I'm thinking this is in fact a bug
[-]Delete Receipt button is not displayed in merged transaction[/-][+][$250] Delete Receipt button is not displayed in merged transaction[/+]melvin-bot commentedon Dec 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021867328664713695509
melvin-bot commentedon Dec 12, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (
External)jliexpensify commentedon Dec 12, 2024
Thanks Joe!
isagoico commentedon Dec 13, 2024
@joekaufmanexpensify @jliexpensify Hi there! This issue came up when I was writing tests for the merge transaction feature. I checked the behavior on OD and in ND and it seems ND is missing the detach receipt/delete receipt option. Had a discussion with @trjExpensify and @mountiny around this and seems it's either a missing feature or a bug.
joekaufmanexpensify commentedon Dec 13, 2024
Cool. TY!
76 remaining items
melvin-bot commentedon Jan 28, 2025
@dukenv0307 / @dominictb @jliexpensify @dukenv0307 / @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
dukenv0307 commentedon Jan 29, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in https://app.slack.com/client/E047TPA624F/C01GTK53T8Q has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
jliexpensify commentedon Feb 4, 2025
Payment Summary
jliexpensify commentedon Feb 4, 2025
@dominictb the previous Upworks job closed, can you accept this one? https://www.upwork.com/jobs/~021886615380373019169
Thanks!
jliexpensify commentedon Feb 5, 2025
Bumping @dominictb to accept in Upworks so I can pay + close!
dominictb commentedon Feb 5, 2025
@jliexpensify Accepted, thank you 🙇
jliexpensify commentedon Feb 5, 2025
Paid and job closed.
@dukenv0307 please refer to this summary.
JmillsExpensify commentedon Feb 20, 2025
$250 approved for @dukenv0307