[HOLD for payment 2024-12-20] [HOLD for payment 2024-12-19] Search - Pay button for held expenses is gray in wide layout, and green in narrow layout

@zanyrenney

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.74-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat.
Submit two expenses.
Hold one of the expenses.
Note that the pay button is gray in main chat and expense report.
Go to Search > Outstanding.
Note that the pay button is also gray.
Switch the layout to narrow layout.

Expected Result:

The pay button for held expenses should be gray in narrow layout.

Actual Result:

The pay button for held expenses is gray in wide layout, and green in narrow layout.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6690711_1733906920735.20241211_164502.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @zanyrenney

@cristipaval

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay button becomes green back when screen is resized to small.

What is the root cause of that problem?

When the screen is large, we pass the shouldUseSuccessStyle correctly.

App/src/components/SelectionList/Search/ReportListItem.tsx

Lines 204 to 214 in c1454f7

    
           {isLargeScreenWidth && ( 
        
               <View style={StyleUtils.getSearchTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.ACTION)}> 
        
                   <ActionCell 
        
                       action={reportItem.action} 
        
                       shouldUseSuccessStyle={!hasHeldExpenses} 
        
                       goToItem={handleOnButtonPress} 
        
                       isSelected={item.isSelected} 
        
                       isLoading={reportItem.isActionLoading} 
        
                   /> 
        
               </View> 
        
           )}

For for small screen, we forgot to pass shouldUseSuccessStyle.

App/src/components/SelectionList/Search/ReportListItem.tsx

Lines 166 to 177 in c1454f7

    
           {!isLargeScreenWidth && ( 
        
               <ExpenseItemHeaderNarrow 
        
                   participantFrom={participantFrom} 
        
                   participantFromDisplayName={participantFromDisplayName} 
        
                   participantTo={participantTo} 
        
                   participantToDisplayName={participantToDisplayName} 
        
                   action={reportItem.action} 
        
                   onButtonPress={handleOnButtonPress} 
        
                   containerStyle={[styles.ph3, styles.pt1half, styles.mb1half]} 
        
                   isLoading={reportItem.isActionLoading} 
        
               /> 
        
           )}

What changes do you think we should make in order to solve the problem?

Pass shouldUseSuccessStyle to ExpenseItemHeaderNarrow.

shouldUseSuccessStyle={!hasHeldExpenses}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

This seems to be the offending PR. Checking to see if the author is available for a fix in the next few hours

Reviewing label has been removed, please complete the "BugZero Checklist".

@mananjadhav

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] fix: grey pay button held expense for small screen #53921

If no regressions arise, payment will be issued on 2024-12-19. 🎊

For reference, here are some details about the assignees on this issue:

@mananjadhav requires payment through NewDot Manual Requests

@mananjadhav

@mananjadhav @zanyrenney @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mananjadhav

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] fix: grey pay button held expense for small screen #53921

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

@mananjadhav requires payment through NewDot Manual Requests

@mananjadhav

@mananjadhav @zanyrenney @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Navigation Menu

Repository navigation

[HOLD for payment 2024-12-20] [HOLD for payment 2024-12-19] Search - Pay button for held expenses is gray in wide layout, and green in narrow layout #53905

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

9 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{isLargeScreenWidth && (
	<View style={StyleUtils.getSearchTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.ACTION)}>
	<ActionCell
	action={reportItem.action}
	shouldUseSuccessStyle={!hasHeldExpenses}
	goToItem={handleOnButtonPress}
	isSelected={item.isSelected}
	isLoading={reportItem.isActionLoading}
	/>
	</View>
	)}

	{!isLargeScreenWidth && (
	<ExpenseItemHeaderNarrow
	participantFrom={participantFrom}
	participantFromDisplayName={participantFromDisplayName}
	participantTo={participantTo}
	participantToDisplayName={participantToDisplayName}
	action={reportItem.action}
	onButtonPress={handleOnButtonPress}
	containerStyle={[styles.ph3, styles.pt1half, styles.mb1half]}
	isLoading={reportItem.isActionLoading}
	/>
	)}

[HOLD for payment 2024-12-20] [HOLD for payment 2024-12-19] Search - Pay button for held expenses is gray in wide layout, and green in narrow layout #53905

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 11, 2024

melvin-bot commented on Dec 11, 2024

melvin-bot commented on Dec 11, 2024

github-actions commented on Dec 11, 2024

bernhardoj commented on Dec 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

cristipaval commented on Dec 11, 2024

9 remaining items

melvin-bot commented on Dec 12, 2024

melvin-bot commented on Dec 12, 2024

melvin-bot commented on Dec 12, 2024

melvin-bot commented on Dec 13, 2024

melvin-bot commented on Dec 13, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions