Repository navigation
[HOLD for payment 2025-02-07] [Performance] Create PING for Pusher Connection #53826
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
What performance issue do we need to solve?
Intermittently, Pusher becomes unreachable for reasons out of our control and the client needs to reconnect to it, which causes delays or failure to get realtime updates to chat data.
We can't count on Pusher's internal PING to detect liveness -- we need our own application layer Pusher-ping.
What is the impact of this on end-users?
A more reliable Pusher-PING means users get realtime updates to their New Expensify data more reliably.
List any benchmarks that show the severity of the issue
This is a recurring issue: https://expensify.slack.com/archives/C05LX9D6E07/p1731299637345689
Proposed solution (if any)
Develop our own application layer Pusher-PING that works in the same way as our existing PING code, but instead tests the Pusher connection.
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)
Note: These should be the same as the benchmarks collected before any changes.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1731299637345689
Issue Owner
Current Issue Owner: @mallenexpensifyMetadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Dec 10, 2024
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
melvin-bot commentedon Dec 10, 2024
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-][Performance] Add PING for Pusher Connection[/-][+][Performance] Create PING for Pusher Connection [/+]muttmuure commentedon Dec 10, 2024
#52437
mallenexpensify commentedon Dec 10, 2024
Checking to see if Deeter wants assignment here. If not I'll add AutoAssignerNewDotQuality to assign an engineer since this is Quality, High status and the other issue is held on this.
Guessing it needs to be Internal
melvin-bot commentedon Dec 13, 2024
Triggered auto assignment to @cristipaval (
AutoAssignerNewDotQuality)56 remaining items
tgolen commentedon Feb 6, 2025
Update
Next Steps
ETA
melvin-bot commentedon Feb 7, 2025
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Feb 10, 2025
I see payment was due a few days ago but I feel like there's more work to do. @ishpaul777 ,
Is there more than just this PR?
ishpaul777 commentedon Feb 11, 2025
This is #55326 the only one i reviewed,. @tgolen can you confirm if there will be more E/App PR planned where I can help? if no I think we can release the payment
tgolen commentedon Feb 11, 2025
mallenexpensify commentedon Feb 12, 2025
@ishpaul777 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021889470488141539583
ishpaul777 commentedon Feb 12, 2025
happy to help! whenever required 😄
Accepted, Thanks!
mallenexpensify commentedon Feb 14, 2025
Upwork is buggy now so I can't pay, will get to next week, sorry @ishpaul777
mallenexpensify commentedon Feb 14, 2025
Contributor+: @ishpaul777 paid $250 via Upwork
I don't think we need a regression test here, comment if you disagree and I can get one created.