Repository navigation
[Due for payment 2025-01-18] [$250] Notification – Have no sound for notification received #53700
Description
Activity
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Can repro!
Job added to Upwork: https://www.upwork.com/jobs/~021866271667566111224
- changed the title
[-]Notification – Have no sound for notification received[/-][+][$250] Notification – Have no sound for notification received[/+]on Dec 10, 2024 Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)119 remaining items
Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.83-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-18. 🎊
For reference, here are some details about the assignees on this issue:
- @jayeshmangwani requires payment through NewDot Manual Requests
- @truph01 requires payment automatic offer (Contributor)
@jayeshmangwani @RachCHopkins @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
BugZero Checklist:
- [Contributor] Classify the bug:
Bug classification
Source of bug:
- 1a. Result of the original design (eg. a case wasn't considered)
- 1b. Mistake during implementation
- 1c. Backend bug
- 1z. Other:
Where bug was reported:
- 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
- 2b. Reported on staging (eg. found during regression or PR testing)
- 2d. Reported on a PR
- 2z. Other:
Who reported the bug:
- 3a. Expensify user
- 3b. Expensify employee
- 3c. Contributor
- 3d. QA
- 3z. Other:
-
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: feat: app sounds #31055 (comment)
-
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
- Log in as user A on Desktop or web
- Open chat with user B
- As user B sends message to user A
- Verify that user A receives a notification with a sound.
Do we agree 👍 or 👎
Reacted by Rachael Hopkins and Mario Mazzotti- changed the title
[-][HOLD for payment 2025-01-18] [$250] Notification – Have no sound for notification received[/-][+][Due for payment 2025-01-18] [$250] Notification – Have no sound for notification received[/+]on Jan 20, 2025 @RachCHopkins, @jayeshmangwani, @truph01, @MarioExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
Payment Summary:
- Contributor: @truph01 to be paid $250 via Upwork
- Contributor+: @jayeshmangwani to be paid $250 via NewDot manual request
Upwork job here
Contributor has been paid, the contract has been completed, and the Upwork post has been closed.
Reacted by Mario Mazzotti$250 approved for @jayeshmangwani
Reacted by Mario Mazzotti
Metadata
Metadata
Labels
Type
Projects
- Status
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): testpayment935+775@gmail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Notification is with sound
Actual Result:
Notification is without sound
Workaround:
Unknown
Platforms:
Screenshots/Videos
View all open jobs on GitHub
Bug6686403_1733490528944.bandicam_2024-12-06_15-16-13-138.mp4
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @RachCHopkins