[HOLD for payment 2024-12-19] [$250] iOS - Search query is cut off at the bottom for certain letters

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.71-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #53317
Email or phone of affected tester (no customers): nathanmulugetatesting+2299@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Open hybrid app
2. Navigate to search
3. Tap on the search icon at the top right corner
4. Type lower case g multiple of times
5. Hit enter

Expected Result:

The letters does not get cut off at the bottom

Actual Result:

The lower case letter g and other letters like lower case p get cut off at the bottom

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

• Reproduced on iPhone 11 and iPhone 13 models.

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021864712686512100060
• Upwork Job ID: 1864712686512100060
• Last Price Increase: 2024-12-05
• Automatic offers:
• suneox | Reviewer | 105260216
• abzokhattab | Contributor | 105260217

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search query is cut off at the bottom for certain letters

What is the root cause of that problem?

in the SearchTypeMenuNarrow component, the container height is set to componentSizeNormal however the text height is set to large

App/src/pages/Search/SearchTypeMenuNarrow.tsx

Lines 181 to 200 in be17e04

	<Animated.View style={[styles.tabSelectorButton, styles.tabBackground(hovered, true, theme.border), styles.w100, StyleUtils.getHeight(variables.componentSizeNormal)]}>
	<View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, titleViewStyles]}>
	<Icon
	src={menuIcon}
	fill={theme.icon}
	small
	/>
	<Text
	numberOfLines={1}
	style={[styles.textStrong, styles.flexShrink1, styles.label]}
	>
	{menuTitle}
	</Text>
	<Icon
	src={Expensicons.DownArrow}
	fill={theme.icon}
	small
	/>
	</View>
	</Animated.View>

App/src/styles/index.ts

Lines 379 to 382 in 2403fcd

	label: {
	fontSize: variables.fontSizeLabel,
	lineHeight: variables.lineHeightLarge,
	},

What changes do you think we should make in order to solve the problem?

• we should either change the view height to be large and match the text height
• or change the text height to normal

                                style={[styles.textStrong, styles.flexShrink1, styles.textLineHeightNormal, styles.fontSizeLabel]}

Result

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

[isabelastisser]

I think hybrid issues need to be internal.

[abzokhattab]

should it be external? i see its happening on ios standalone as well not only the hybrid.

for reference here is a similar issue #49890