Skip to content

[HOLD for payment 2024-12-30] [$125] Inconsistency on bottom padding for submit button in issue expensify card flow #53583

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @koko57
Slack conversation (hyperlinked to channel name):

Action Performed:

Break down in numbered steps

  1. Submit a physical card
  2. Notice the gap in the Issue Card button from the bottom
  3. compare it with the Submit button on the validate magic code

Expected Result:

Describe what you think should've happened

The submit button should have the same bottom padding everywhere

Actual Result:

Describe what actually happened
image
image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021865895438137903488
  • Upwork Job ID: 1865895438137903488
  • Last Price Increase: 2024-12-08
  • Automatic offers:
    • allgandalf | Reviewer | 105306702
    • Krishna2323 | Contributor | 105306704
Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 4, 2024
  2. self-assigned this
    on Dec 4, 2024
  3. moved this to Bugs and Follow Up Issues in #expensify-bugson Dec 4, 2024
  4. mountiny commented on Dec 4, 2024

    @mountiny
    ContributorAuthor
  5. koko57 commented on Dec 5, 2024

    @koko57
    Contributor

    I would like to work on this issue 🙂

  6. mountiny commented on Dec 6, 2024

    @mountiny
    ContributorAuthor

    @koko57 how is this looking?

  7. mountiny commented on Dec 6, 2024

    @mountiny
    ContributorAuthor

    We can make this external too

  8. koko57 commented on Dec 6, 2024

    @koko57
    Contributor

    I will work on it on Monday, today Im ooo

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 8, 2024
  10. 46 remaining items

  11. allgandalf commented on Jan 2, 2025

    @allgandalf
    Contributor

    not overdue

  12. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    @johncschuster, @mountiny, @Krishna2323, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @johncschuster, @mountiny, @Krishna2323, @allgandalf Still overdue 6 days?! Let's take care of this!

  14. johncschuster commented on Jan 6, 2025

    @johncschuster
    Contributor

    Hey folks! I'm back from OOO and will work on issuing payment now. Thanks for your patience!

  15. johncschuster commented on Jan 6, 2025

    @johncschuster
    Contributor

    @Krishna2323, can you please accept the job on Upwork?

  16. johncschuster commented on Jan 6, 2025

    @johncschuster
    Contributor

    I've issued payment to @allgandalf and will issue payment to @Krishna2323 once the job has been accepted 👍

  17. Krishna2323 commented on Jan 6, 2025

    @Krishna2323
    Contributor

    @johncschuster I have accepted the offer, thanks.

  18. johncschuster commented on Jan 7, 2025

    @johncschuster
    Contributor

    I've issued payment! Thanks for your contributions!

  19. moved this from Hold for Payment to Done in #expensify-bugson Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions