Repository navigation
[$250] Code block markdown renders incorrectly #53573
Description
Activity
- addedDailyKSv2KSv2BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.
on Dec 4, 2024 Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...
- addedExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor
on Dec 11, 2024 Job added to Upwork: https://www.upwork.com/jobs/~021866767677427055045
- changed the title
[-]Code block markdown renders incorrectly[/-][+][$250] Code block markdown renders incorrectly[/+]on Dec 11, 2024 - addedHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors
on Dec 11, 2024 Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)This isn't really related to convert/migrate/retain so I added it to quality.
27 remaining items
@JmillsExpensify, @allroundexperts, @jasperhuangg, @QichenZhu Huh... This is 4 days overdue. Who can take care of this?
@JmillsExpensify, @allroundexperts, @jasperhuangg, @QichenZhu 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Update: #54685 has been merged, and I verified it fixed this issue.
Screenshots/Videos
Android: Native
android-native.mp4
Android: mWeb Chrome
android-web.mp4
iOS: Native
ios-native.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
mac-web.mov
MacOS: Desktop
mac-desktop.mp4
@JmillsExpensify, @allroundexperts, @jasperhuangg, @QichenZhu 10 days overdue. I'm getting more depressed than Marvin.
The PR has been deployed to production.
Payment summary:
- Contributor: @QichenZhu $250 via Upwork
- Reviewer: @allroundexperts $250 via New Expensify
Contributor paid out, so all that is left is BZ checklist and New Expensify request. Closing this out until then.
Reacted by Qichen ZhuBugZero Checklist:
- [Contributor] Classify the bug:
Bug classification
Source of bug:
- 1a. Result of the original design (eg. a case wasn't considered)
- 1b. Mistake during implementation
- 1c. Backend bug
- 1z. Other:
Where bug was reported:
- 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
- 2b. Reported on staging (eg. found during regression or PR testing)
- 2d. Reported on a PR
- 2z. Other:
Who reported the bug:
- 3a. Expensify user
- 3b. Expensify employee
- 3c. Contributor
- 3d. QA
- 3z. Other:
-
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: There wasn't a single PR that introduced this. It has been missing this case since the start.
-
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
-
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
- N/A
Test:
- In any chat, type the following message - "hello `` hi`" (remove double quotes)
- Send the message
Verify that the message composed as hello `` hi`
Do we agree 👍 or 👎
Payment summary:
Contributor: @QichenZhu $250 via Upwork
Reviewer: @allroundexperts $250 via New Expensify$250 approved for @allroundexperts
Metadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MonilBhavsar
Slack conversation (hyperlinked to channel name): expensify_bugs
Action Performed:
hello`` hi`" (remove double quotes)Expected Result:
Message composed as
hello`` hi`Actual Result:
Message composed as
hello`` hi`Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allroundexperts