[HOLD for payment 2024-12-20] [$250] Screen briefly flashes Chase feed page after connecting Amex feed and back to expensify

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): ts_external_expensify_expense

Action Performed:

1. Enable company card in workspace
2. Click Add card and choose Amex bank
3. Connect to Amex using Direct feed
4. Click Return to Expensify

Expected Result:

User returned to company cards page

Actual Result:

Screen briefly flashes Chase feed page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2024-12-02_16-35-27.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866127944349300492
• Upwork Job ID: 1866127944349300492
• Last Price Increase: 2024-12-09

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dukenv0307]

I already worked on company card project so I would like to take it as C+

[joekaufmanexpensify]

We're discussing in the thread that maybe this will be fixed elsewhere

[DylanDylann]

@mountiny @joekaufmanexpensify I tried to reproduce this bug from my side. I used a mock response from here. Let's see this video

Screen.Recording.2024-12-06.at.23.45.19.mov

When clicking mock data (it means that when BE returns data) the App opens the bank connection URL again. The RCA of this problem:

App/src/pages/workspace/companyCards/addNew/BankConnection/index.tsx

Lines 72 to 92 in 96f7fdd

	useEffect(() => {
	if (!url) {
	return;
	}
	if (isNewFeedConnected) {
	customWindow?.close();
	if (newFeed) {
	Card.updateSelectedFeed(newFeed, policyID ?? '-1');
	}
	Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID ?? '-1'));
	return;
	}
	if (isBankConnectionCompleteRoute) {
	customWindow?.close();
	return;
	}
	customWindow = openBankConnection(url);
	}, [isNewFeedConnected, newFeed, isBankConnectionCompleteRoute, policyID, url]);
	return (
	<ScreenWrapper testID={BankConnection.displayName}>

When isNewFeedConnected is true, we close the connection URL and navigate to the company card page. But this useEffect is triggered again before navigating --> the URL is opened again. You guys can see my log on the above video for more detail

I suspect that this was caused by this PR
cc @allgandalf @VickyStash

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.