[HOLD for payment 2024-12-16] [$250] The error message displayed when attempting to proceed without selecting a bank while adding a feed is unclear

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): ts_external_expensify_expense

Action Performed:

1. Enable company card in workspace
2. Click Add card
3. Without choosing any bank click Next

Expected Result:

Error message displayed for not selecting bank

Actual Result:

The error message displayed when attempting to proceed without selecting a bank while adding a feed is unclear. It states: "Please select a bank account before continuing."

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021865184188126712540
• Upwork Job ID: 1865184188126712540
• Last Price Increase: 2024-12-06

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message displayed when attempting to proceed without selecting a bank while adding a feed is unclear

What is the root cause of that problem?

We are defining error message here with the message "Please select a bank account before continuing." and it is not clear because we are not adding a bank account.

App/src/languages/en.ts

Line 3313 in 0eec30d

pleaseSelectBankAccount: 'Please select a bank account before continuing.',

What changes do you think we should make in order to solve the problem?

We can change this to "Please select a bank before continuing." or something to make it clearer

App/src/languages/en.ts

Line 3313 in 0eec30d

pleaseSelectBankAccount: 'Please select a bank account before continuing.',

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[narefyev91]

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

[dukenv0307]

I already worked on company card project so I would like to take it as C+