Repository navigation
[HOLD for payment 2024-12-19] [$250] Split- Deleted workspace is still shown in recents list #53392
Description
Activity
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.- changed the title
[-]Split- "Unavailable workspace" is shown for selected workspace and "Hidden" when clicked on it[/-][+]Split- Deleted workspace is still shown in recents list[/+]on Dec 4, 2024 I think the actual bug here is that the deleted workspace shows up in the recents list. We shouldn't show the deleted workspace in any selectable list for choosing where to submit or who to split with.
All the other weird behavior after selecting the deleted workspace is irrelevant because it shouldn't be there in the first place.
- changed the title
[-]Split- Deleted workspace is still shown in recents list[/-][+][$250] Split- Deleted workspace is still shown in recents list[/+]on Dec 4, 2024 Job added to Upwork: https://www.upwork.com/jobs/~021864448103150318798
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.
15 remaining items
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-19. 🎊
For reference, here are some details about the assignees on this issue:
- @Ollyws requires payment through NewDot Manual Requests
- @narefyev91 does not require payment (Contractor)
@Ollyws @sakluger @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
BugZero Checklist:
- [Contributor] Classify the bug:
Bug classification
Source of bug:
- 1a. Result of the original design (eg. a case wasn't considered)
- 1b. Mistake during implementation
- 1c. Backend bug
- 1z. Other:
Where bug was reported:
- 2a. Reported on production
- 2b. Reported on staging (deploy blocker)
- 2c. Reported on both staging and production
- 2d. Reported on a PR
- 2z. Other:
Who reported the bug:
- 3a. Expensify user
- 3b. Expensify employee
- 3c. Contributor
- 3d. QA
- 3z. Other:
-
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/52233/files#r1890577333
-
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template -
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
1. Go to staging.new.expensify.com 2. Go to workspace chat 3. Split an expense in the workspace chat 4. Delete the workspace 5. Open FAB 6. Click Split expense under Quick action section 7. Enter amount > Next 8. Select any workspace 9. Verify that selection is working correctlyDo we agree 👍 or 👎
Thanks for the regression test steps. I added a step to verify that the deleted workspace did not show up in the list, but otherwise, looks great. 👍
Payment Summary
- Reviewer: @Ollyws owed $250 via NewDot
- Contributor: @narefyev91 is from an agency-contributor and not due payment
BugZero Checklist (@sakluger)
- I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1864448103150318798/hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
Requested in ND.
$250 approved for @Ollyws
@sakluger, @amyevans, @Ollyws, @narefyev91 Eep! 4 days overdue now. Issues have feelings too...
Thanks everyone!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+232803@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Expected Result:
In Step 9, the selected workspace will not display "Unavailable workspace"In Step 11, "Hidden" will not be shown every time the selected workspace is clickedIn Step 7, the deleted workspace should not be displayed in the recents list.
Actual Result:
In Step 7, the deleted workspace is displayed in the recents list.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6682129_1733156311149.20241203_001105.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @sakluger