[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Submit expense - Next Steps shows "Waiting for You to pay" when payment is blocked by violations

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.67-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+bm1jd9@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Create workspace
3. Go to categories > settings > enable "Members must categorize all expenses"
4. Go to the workspace chat and submit an expense
5. Click on the expense preview then see the next steps.

Expected Result:

The next steps should ask the user to fix the violation instead of stating "Waiting for You to pay."

Actual Result:

The next steps message displays "Waiting for You to pay expense(s)" even when payment is blocked due to a violation.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6677287_1732646867926.bandicam_2024-11-26_21-45-13-469.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

Screen.Recording.2024-11-26.at.20.56.11.mp4

@IuliiaHerets @kavimuru, I could repro this in production. Did the tester test this change in production before labelling it as a blocker?

Gonna remove the label, but we should look into it.

I assume the problem is that its the admin/policy owner and the submitter all in one so probably the logic is incorrectly picking priority.