[Awaiting pending offer] [$125] mWeb - Copilot - User navigated to incorrect page when using device back button in MC page

@dominictb

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+36@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Open the staging.new.expensify.com website
Tap on "Settings" on the bottom of the screen
Tap on "Security" and select "Add Copilot"
Select any user as copilot
Select an access level
Tap on "Add Copilot"
On Magic Code page, use the device back button to return to previous page
Verify you are redirected to copilot confirmation page

Expected Result:

When using the device back button to return to previous page on magic code page while adding copilot, the user should land on the copilot confirmation page

Actual Result:

User lands on "Access Level" page instead of copilot confirmation, when using the device back button while in the Magic Code page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6673914_1732346029419.Copilot.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021861786354506701472
Upwork Job ID: 1861786354506701472
Last Price Increase: 2024-11-27
Automatic offers:

dominictb | Reviewer | 105157484
daledah | Contributor | 105157485

Issue Owner

Current Issue Owner: @dominictb

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Edited by proposal-police: This proposal was edited at 2024-11-26 11:01:06 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User lands on "Access Level" page instead of copilot confirmation, when using the device back button while in the Magic Code page

What is the root cause of that problem?

The MC page is just a modal:

App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx

Line 79 in 0135d4e

<DelegateMagicCodeModal

so when pressing on back button, the navigate user to the Access Level page.

What changes do you think we should make in order to solve the problem?

We should user the modal:

App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx

Line 79 in 0135d4e

<DelegateMagicCodeModal

as:

            <DelegateMagicCodeModal shouldHandleNavigationBack ... /> // can use shouldHandleNavigationBack={Browser.isMobileChrome()}

The shouldHandleNavigationBack will be passed down to Modal component:

App/src/components/Modal/index.tsx

Line 10 in 0135d4e

    
           function Modal({fullscreen = true, onModalHide = () => {}, type, onModalShow = () => {}, children, shouldHandleNavigationBack, ...rest}: BaseModalProps) {

and is used in:

App/src/components/Modal/index.tsx

Lines 50 to 53 in 0135d4e

    
           if (shouldHandleNavigationBack) { 
        
               window.history.pushState({shouldGoBack: true}, '', null); 
        
               window.addEventListener('popstate', handlePopStateRef.current); 
        
           }

With this, pressing back button will navigate user to the correct page.

What alternative solutions did you explore? (Optional)

Web:

53007.web.mp4

iOS:

trim.005F5C80-52FD-4509-8356-82F6AC748275.MOV

Android mWeb Chrome:

screen-20241126-232231.mp4

I cannot recreate.

@twisterdotcom

@twisterdotcom I can replicate this bug on the web (by using the browser back button in case MacOS chrome and device back button in case android chrome). In your video, it seems you used the back button within the app, but the OP specified that the device's back button should be used:

Screen.Recording.2024-11-27.at.10.47.24.mov

Screen.Recording.2024-11-27.at.08.56.06.mov

Ah, my android device doesn't have a back button, I guess I would need to enable it in the settings. Okay, browser made it much easier. I agree then, this is a bug. Niche though.

Job added to Upwork: https://www.upwork.com/jobs/~021861786354506701472

@twisterdotcom

@twisterdotcom @dominictb @daledah @MarioExpensify this issue is now 4 weeks old, please consider:

Finding a contributor to fix the bug
Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@twisterdotcom

@twisterdotcom, @dominictb, @daledah, @MarioExpensify Eep! 4 days overdue now. Issues have feelings too...

@dominictb

Waiting on @dominictb to accept the Upwork offer now.

@twisterdotcom This is done, thanks.

@twisterdotcom

@twisterdotcom, @dominictb, @daledah, @MarioExpensify Huh... This is 4 days overdue. Who can take care of this?

@twisterdotcom

I think this can be closed now, but I'll wait @twisterdotcom to be back
Edit: Moving this to Weekly just to clear up my dashboard

Navigation Menu

Repository navigation

[Awaiting pending offer] [$125] mWeb - Copilot - User navigated to incorrect page when using device back button in MC page #53007

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

45 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (shouldHandleNavigationBack) {
	window.history.pushState({shouldGoBack: true}, '', null);
	window.addEventListener('popstate', handlePopStateRef.current);
	}

[Awaiting pending offer] [$125] mWeb - Copilot - User navigated to incorrect page when using device back button in MC page #53007

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 23, 2024

daledah commented on Nov 26, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

twisterdotcom commented on Nov 26, 2024

daledah commented on Nov 27, 2024

twisterdotcom commented on Nov 27, 2024

melvin-bot commented on Nov 27, 2024

45 remaining items

melvin-bot commented on Dec 21, 2024

melvin-bot commented on Dec 23, 2024

dominictb commented on Dec 23, 2024

melvin-bot commented on Dec 30, 2024

MarioExpensify commented on Dec 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions