Repository navigation
[HOLD for payment 2024-12-20] Investigate useOnyx infinite loading state related to the Connection Manager #52640
Description
This issue was first noticed here -> #49509.
I recently implemented a fix in Onyx to solve the infinite loading states after a Onyx.clear() operation, but in this case they are happening without the clear operation, so we must investigate it again.
Report of the problem: #49509 (comment)
Reproducible steps: #49509 (comment)
My initial investigations: #49509 (comment)
Activity
fabioh8010 commentedon Nov 25, 2024
Hi @gijoe0295 Could you confirm for me if you are still being able to reproduce this loading state issue? I'm having difficulties to reproduce it. If you are able could you give me the detailed test steps again? Thanks
fabioh8010 commentedon Nov 28, 2024
@ishpaul777 maybe you can help me here with reproducing the problem from your side? We need to remove
reuseConnection: falsefromsrc/pages/workspace/withPolicy.tsxbefore testing.ishpaul777 commentedon Nov 28, 2024
I'll check a confirm in few hours
ishpaul777 commentedon Dec 1, 2024
Tried multiple times, no luck reproducing this is resolved mysteriously
Screen.Recording.2024-12-01.at.10.10.10.PM.mov
fabioh8010 commentedon Dec 2, 2024
@ishpaul777 Should we close this issue then? I asked @kubabutkiewicz to help me with testing and he wasn't able to reproduce it too.
fabioh8010 commentedon Dec 2, 2024
However we can try removing
reuseConnection: falsefromwithPolicyand see if a regression will occur from that. WDYT?ishpaul777 commentedon Dec 2, 2024
yes i think that should be a good next step forward 👍
fabioh8010 commentedon Dec 4, 2024
Update: Created a WIP Draft PR. Will proceed with testing soon.
fabioh8010 commentedon Dec 5, 2024
@ishpaul777 PR open to review!
melvin-bot commentedon Dec 10, 2024
Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
6 remaining items
melvin-bot commentedon Dec 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-20. 🎊
melvin-bot commentedon Dec 20, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Dec 23, 2024
@neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Dec 24, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.neil-marcellini commentedon Dec 24, 2024
Assigning @bfitzexpensify to handle payment stuff 🙏
bfitzexpensify commentedon Dec 24, 2024
Offer sent @ishpaul777
bfitzexpensify commentedon Dec 27, 2024
Payment complete.