[HOLD for payment 2024-12-05] [$250] Search - Expenses change position briefly when switching from Settings to Search

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh051101@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Have many expenses

1. Go to staging.new.expensify.com
2. Go to Search
3. Change sorting a few times (click Merchant, From, To etc)
4. Click Settings
5. Go back to Search
6. Might need to repeat Step 4 and 5 a few times to see the expenses changing position briefly

Expected Result:

The expenses will not change position briefly when switching from Settings to Search after changing sorting order.

Actual Result:

The expenses change position briefly when switching from Settings to Search after changing sorting order.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6666515_1731688014152.20241116_002207.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021858539185487721038
• Upwork Job ID: 1858539185487721038
• Last Price Increase: 2024-11-18
• Automatic offers:
• FitseTLT | Contributor | 105027229

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Expenses change position briefly when switching from Settings to Search

What is the root cause of that problem?

When we sort string sortProperties we are converting reference string to lowercase while leaving the compare string intact

App/src/libs/SearchUIUtils.ts

Line 400 in 09f6db7

return sortOrder === CONST.SEARCH.SORT_ORDER.ASC ? aValue.toLowerCase().localeCompare(bValue) : bValue.toLowerCase().localeCompare(aValue);

This will break the reflexive rule of compareFunctions so the sort will be unstable. According to MDN compareFunction should have several properties one is reflexive that is compareFuntion(a,a) when the arguments are equal the compare function should always return 0.

What changes do you think we should make in order to solve the problem?

We should compare the strings, both the reference and compareString, with the same form, either without touching it or converting it to the same form

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021858539185487721038

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[isabelastisser]

@jjcoffee can you please review the proposal above? Thanks!