[HOLD for payment 2024-12-07] [$250] No RBR on Subscription row in the LHN in settings if the free trial has expired

@allgandalf

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.62-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allgandalf
Slack conversation (hyperlinked to channel name): Expensify bugs

Action Performed:

Open an account who free trial has expired
Go to settings > Subscription

Expected Result:

RBR should also be on the Subscription row in the LHN

Actual Result:

Observe that there is a RBR on the Page but not on the settings option

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021858434959504168009
Upwork Job ID: 1858434959504168009
Last Price Increase: 2024-11-18
Automatic offers:

daledah | Contributor | 104948042

Issue Owner

Current Issue Owner: @zanyrenney

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

No RBR on Subscription row in the LHN in settings if the free trial has expired

What is the root cause of that problem?

We are checking the condition to show RBR in the sidebar here, it depends on function hasSubscriptionRedDotError here

And with case POLICY_OWNER_WITH_AMOUNT_OWED_OVERDUE we didn't update isError=true

App/src/pages/settings/InitialSettingsPage.tsx

Line 198 in 6ba2c97

    
           brickRoadIndicator: !!privateSubscription?.errors || SubscriptionUtils.hasSubscriptionRedDotError() ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,

App/src/libs/SubscriptionUtils.ts

Lines 356 to 358 in 6ba2c97

    
           function hasSubscriptionGreenDotInfo(): boolean { 
        
               return getSubscriptionStatus()?.isError === false; 
        
           }

What changes do you think we should make in order to solve the problem?

Simply we only need to add isError=true here

App/src/libs/SubscriptionUtils.ts

Lines 272 to 274 in 6ba2c97

    
           return { 
        
               status: PAYMENT_STATUS.POLICY_OWNER_WITH_AMOUNT_OWED_OVERDUE, 
        
           };

Noted: We should check again with another case that we need to RBR

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

No RBR on Subscription row in the LHN in settings if the free trial has expired

What is the root cause of that problem?

On settings row, we do not check the card error for brickRoadIndicator:

App/src/pages/settings/InitialSettingsPage.tsx

Line 198 in 04d85d8

    
           brickRoadIndicator: !!privateSubscription?.errors || SubscriptionUtils.hasSubscriptionRedDotError() ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,

This causes the bug as there will be no RBR for outdated payment methods.

What changes do you think we should make in order to solve the problem?

Like we do on the cardSection in subscription page , we should add a check for cards errors CardSectionUtils.getBillingStatus(translate, defaultCard?.accountData ?? {})?.isErrow in the settings page as well:

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Line 68 in 04d85d8

    
           const [billingStatus, setBillingStatus] = useState<BillingStatusResult | undefined>(CardSectionUtils.getBillingStatus(translate, defaultCard?.accountData ?? {}));

We will get the defaultCard from fundList, same like we do in cardSection:

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Line 54 in 04d85d8

    
           const defaultCard = useMemo(() => Object.values(fundList ?? {}).find((card) => card.accountData?.additionalData?.isBillingCard), [fundList]);

brickRoadIndicator: !!privateSubscription?.errors || SubscriptionUtils.hasSubscriptionRedDotError() || CardSectionUtils.getBillingStatus(translate, defaultCard?.accountData ?? {})?.isError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021858434959504168009

@hungvu193

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@hungvu193

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: show RBR on Subscription row with exprired free trial #52742

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment through NewDot Manual Requests
@daledah requires payment automatic offer (Contributor)
@allgandalf requires payment (Needs manual offer from BZ)

@hungvu193

@hungvu193 @zanyrenney @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/44072/files#r1875328860
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

Open an account with free trial expired
Go to settings > Subscription
Verify that: RBR is displayed on LHN

Do we agree 👍 or 👎

@hungvu193

@hungvu193, @cristipaval, @zanyrenney, @daledah Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hungvu193

payment summary

@hungvu193 requires payment through NewDot Manual Requests - please request $250 on ND
@daledah requires payment automatic offer (Contributor) - paid via upwork
@allgandalf requires payment (Needs manual offer from BZ)

@hungvu193

$250 approved for @hungvu193

@allgandalf

@allgandalf invited you for the bug bounty here- https://www.upwork.com/jobs/~021867267566328938332

@allgandalf

Paid @allgandalf $50 via upwork too!

Navigation Menu

Repository navigation

[HOLD for payment 2024-12-07] [$250] No RBR on Subscription row in the LHN in settings if the free trial has expired #52598

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

16 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Regression Test Proposal

Test:

payment summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function hasSubscriptionGreenDotInfo(): boolean {
	return getSubscriptionStatus()?.isError === false;
	}

	return {
	status: PAYMENT_STATUS.POLICY_OWNER_WITH_AMOUNT_OWED_OVERDUE,
	};

[HOLD for payment 2024-12-07] [$250] No RBR on Subscription row in the LHN in settings if the free trial has expired #52598

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 14, 2024

daledah commented on Nov 14, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

twilight2294 commented on Nov 14, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Nov 18, 2024

melvin-bot commented on Nov 18, 2024

16 remaining items

melvin-bot commented on Nov 30, 2024

melvin-bot commented on Nov 30, 2024

melvin-bot commented on Nov 30, 2024

hungvu193 commented on Dec 9, 2024

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

hungvu193 commented on Dec 9, 2024

Regression Test Proposal

Test:

melvin-bot commented on Dec 11, 2024

zanyrenney commented on Dec 11, 2024

payment summary

garrettmknight commented on Dec 12, 2024

zanyrenney commented on Dec 12, 2024

zanyrenney commented on Dec 12, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions