Skip to content

[HOLD for payment 2024-11-29] [$250] Android - App crashes when create new chat #52496

Closed
Closed
[HOLD for payment 2024-11-29] [$250] Android - App crashes when create new chat#52496
Assignees
rlinozahmedGaber93VictoriaExpensifyQichenZhu
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Nov 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): gocemate+a2809@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Login with gmail account
  2. Go to FAB> Start chat> Add email address> Finish the flow
  3. Go to FAB> Start chat

Expected Result:

App should not crash

Actual Result:

App crashes when create second new chat from FAB

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1311.txt

Bug6664126_1731518654303.Recording__4507.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021856802999983156406
  • Upwork Job ID: 1856802999983156406
  • Last Price Increase: 2024-11-13
  • Automatic offers:
    • ahmedGaber93 | Reviewer | 104951617
    • QichenZhu | Contributor | 104951622
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 13, 2024
  2. melvin-bot
    assigned
    rlinoz
    and
    VictoriaExpensify
    and unassigned
    rlinoz
    on Nov 13, 2024

  3. melvin-bot commented on Nov 13, 2024

    @melvin-bot
    melvin-botBot
    on Nov 13, 2024 – with Melvin Bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 13, 2024

    @melvin-bot
    melvin-botBot
    on Nov 13, 2024 – with Melvin Bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Nov 13, 2024

    @melvin-bot
    melvin-botBot
    on Nov 13, 2024 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  6. melvin-bot
    added
    DailyKSv2
    on Nov 13, 2024
  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Nov 13, 2024

  8. github-actions commented on Nov 13, 2024

    @github-actions
    github-actionsBot
    on Nov 13, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. francoisl commented on Nov 13, 2024

    @francoisl
    francoisl
    on Nov 13, 2024
    Contributor

    So far I'm unable to repro on my physical device, let's look at the logs though.

  10. rlinoz commented on Nov 13, 2024

    @rlinoz
    rlinoz
    on Nov 13, 2024
    Contributor

    yeah, me neither, tried straight from the staging branch and from the app on the store and nothing.

  11. 49 remaining items

  12. melvin-bot
    removed
    ReviewingHas a PR in review
    on Nov 22, 2024

  13. melvin-bot commented on Nov 22, 2024

    @melvin-bot
    melvin-botBot
    on Nov 22, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-29. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Nov 22, 2024

    @melvin-bot
    melvin-botBot
    on Nov 22, 2024 – with Melvin Bot

    @ahmedGaber93 @VictoriaExpensify @ahmedGaber93 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Nov 29, 2024

  16. VictoriaExpensify commented on Dec 2, 2024

    @VictoriaExpensify
    VictoriaExpensify
    on Dec 2, 2024
    Contributor

    Hey @ahmedGaber93 - can you please complete the checklist in the comment above and accept our offer in Upwork so I can pay you? https://www.upwork.com/nx/wm/offer/104951617

    Contributor: @QichenZhu paid $250 via Upwork

  17. ahmedGaber93 commented on Dec 2, 2024

    @ahmedGaber93
    ahmedGaber93
    on Dec 2, 2024
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: external libraries react-native-reanimated and react-native

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other: Applause Internal Team

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A. It is a known issue external library Android App crash on scrollTo With PanGesture software-mansion/react-native-reanimated#6418 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Android native only

    1. Tap FAB > Start chat > Go back by swiping or using header back button.
    2. Repeat the above steps multiple times (~10 times) and verify the app is not crashed.

    Do we agree 👍 or 👎

  18. ahmedGaber93 commented on Dec 2, 2024

    @ahmedGaber93
    ahmedGaber93
    on Dec 2, 2024
    Contributor

    can you please complete the checklist in the comment above and accept our offer in Upwork so I can pay you?

    @VictoriaExpensify Checklist have been completed, and I will get paid via NewDot

  19. melvin-bot
    added
    Overdue
    on Dec 4, 2024

  20. VictoriaExpensify commented on Dec 5, 2024

    @VictoriaExpensify
    VictoriaExpensify
    on Dec 5, 2024
    Contributor

    Raised a request to add the regression test to test rail - https://github.com/Expensify/Expensify/issues/450650

  21. melvin-bot
    removed
    Overdue
    on Dec 5, 2024

  22. VictoriaExpensify commented on Dec 5, 2024

    @VictoriaExpensify
    VictoriaExpensify
    on Dec 5, 2024
    Contributor

    Update Payment Summary:
    Contributor: @QichenZhu paid $250 via Upwork
    C+: @ahmedGaber93 owed $250 via NewDot

  23. VictoriaExpensify
    closed this as completedon Dec 5, 2024
  24. github-project-automation
    moved this to Done in [#whatsnext] #qualityon Dec 5, 2024

  25. JmillsExpensify commented on Dec 5, 2024

    @JmillsExpensify
    JmillsExpensify
    on Dec 5, 2024
    Contributor

    $250 approved for @ahmedGaber93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions