Skip to content

[$250] Android - Chat- Group name not saved if changed offline and not here tab when opening header #52484

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the Expensify app.
  2. Turn off internet connection.
  3. Tap on FAB and select "Start Chat"
  4. Add a few users and start a group chat.
  5. Tap on group´s header.
  6. Tap on the group´s name and change it.
  7. Return to chat.
  8. Turn on internet connection.
  9. Verify that the new name is still displayed on header.
  10. Tap on header.
  11. Verify all the information is properly displayed.

Expected Result:

After creating group offline, the user should be able to change it´s name and the new one should be saved after recovering internet connection.

Actual Result:

After creating a new group offline and changing the name, the new name is not saved when recovering internet connection, and also, tapping on header, leads to "Hmm, it´s not here" tab.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6663890_1731507952139.Not_Group.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021856723825193050849
  • Upwork Job ID: 1856723825193050849
  • Last Price Increase: 2024-11-13
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 13, 2024
  2. melvin-bot commented on Nov 13, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 13, 2024

    @melvin-bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 13, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 13, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. Julesssss commented on Nov 13, 2024

    @Julesssss
    Contributor

    Users can still use the chat in this case; they are just unable to rename existing chats if they are offline IMMEDIATELY after creating them. We can update existing group chat headers while offline without any issues.

    So I am demoting.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 13, 2024
  8. changed the title [-]Android - Chat- Group name not saved if changed offline and not here tab when opening header[/-] [+][$250] Android - Chat- Group name not saved if changed offline and not here tab when opening header[/+] on Nov 13, 2024
  9. melvin-bot commented on Nov 13, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 13, 2024
  11. melvin-bot commented on Nov 13, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

  12. Julesssss commented on Nov 13, 2024

    @Julesssss
    Contributor

    I can't see any obvious candidates for this regression on the checklist 😕

  13. allgandalf commented on Nov 13, 2024

    @allgandalf
    Contributor

    This issue seems to be fixed on latest main @ZhenjaHorbach

  14. ZhenjaHorbach commented on Nov 13, 2024

    @ZhenjaHorbach
    Contributor

    This issue seems to be fixed on latest main @ZhenjaHorbach

    Thanks for the info
    I will check today !

  15. ZhenjaHorbach commented on Nov 15, 2024

    @ZhenjaHorbach
    Contributor

    Hmmm
    Yeah
    Tried to reproduce one hour on Android App and Web
    But no luck
    Looks like this issue really fixed on the last main

  16. twisterdotcom commented on Nov 15, 2024

    @twisterdotcom
    Contributor

    Let's close and get on with our days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions