Repository navigation
Web - Focus Mode popup is not closed by device back button #52467
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #52072
Email or phone of affected tester (no customers): testpayment935+609@gmail.com
Issue reported by: Applause Internal Team
Action Performed:
- In an account with "Focus" mode enabled, change the mode to "Most Recent"
- Type "Onyx.set("focusModeNotification",true);" in console and get focus mode notification instantly
- Use device back button try to close focusMode popup
Expected Result:
Using device back button when focusMode popup is visible, focusMode popup should be closed.
Actual Result:
FocusMode popup is not closed by device back button.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Nov 13, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Nov 13, 2024
This might be expected as for web the modal should close on press of esc only
App/src/components/Modal/BaseModal.tsx
Line 230 in d1e30bb
ChavdaSachin commentedon Nov 13, 2024
Yes this is expected here, Backspace button on keyboard does not count as device back button.
Despite see
#52072 (comment)
So right now Test 2 is super specific to Android Native.
lschurr commentedon Nov 13, 2024
Closing since this is expected behavior.