[HOLD for payment 2024-11-28] Web - Pay someone-Wallet page displayed in central pane instead of 1:1 chat after validating account

@muttmuure

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.61.0
Reproducible in staging?: Y
Reproducible in production?: Not repro in Prod, App logging out
Issue was found when executing this PR: #50835
Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/ and log in with a new account
Select Something else on the onboarding modal
Click on FAB > Start chat and enter an email of another user
In 1:1 chat click on + > Pay someone
Enter the amount and proceed to the next step
Select Pay with Expensify
Enter correct code

Expected Result:

1:1 chat is still displayed in the central pane

Actual Result:

Wallet page is displayed in the central pane instead of 1:1 chat

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6663364_1731472487738.Recording__946.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @muttmuure

@muttmuure

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Gonals

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Production has the following behaviour

bandicam.2024-11-13.06-52-45-471.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay someone-Wallet page displayed in central pane instead of 1:1 chat after validating account

What is the root cause of that problem?

We are not passing backTo route here

App/src/components/SettlementButton/index.tsx

Line 194 in 4d9be4e

Navigation.navigate(ROUTES.SETTINGS_WALLET_VERIFY_ACCOUNT.route);

What changes do you think we should make in order to solve the problem?

We should add backTo route here. We can do something like this here

 if (!isUserValidated) {
                const activeRoute = Navigation.getActiveRoute();
                Navigation.navigate(ROUTES.SETTINGS_WALLET_VERIFY_ACCOUNT.getRoute(activeRoute));
                return;
            }

What alternative solutions did you explore? (Optional)

@arosiclair

@arosiclair, @muttmuure, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

fix: add Verify account page

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: f7310b1#r149812246
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: Not critical enough to start a discussion
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

None

Test:

Log in with a new account
Open a chat with another user
Click + > Pay someone
Enter the amount
Select Pay with Expensify
Enter the correct magic code in the verification modal and verify.
Verify that you're navigated back to the payment page
Verify that the Central pane still displays the chat
Go to Settings > Wallet > Add bank account
Enter the correct magic code in the verification modal and verify.
Verify that you're navigated back to the bank account addition page and central pane does not change.
Go to Settings > Wallet > Enable wallet
Enter the correct magic code in the verification modal and verify.
Verify that you're navigated back to the enable wallet page and central pane does not change.

Do we agree 👍 or 👎

@arosiclair

@arosiclair, @muttmuure, @c3024 Huh... This is 4 days overdue. Who can take care of this?

@c3024

@c3024 the payment date is on the day you are eligible for payment on New Expensify. Are you planning on submitting your request there?

@sonialiap

Yes. @sonialiap is in the process of adding me to ND payments workspace. Thanks!

@c3024

@c3024 you've been added on our end 🎉 I sent an email with some steps to you yesterday. Please take a look and follow the steps outlined there. Let me know if you have any questions!

Requested on ND.

@arosiclair

@arosiclair, @muttmuure, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@c3024

$250 approved for @c3024 based on this summary.

@arosiclair

@arosiclair, @muttmuure, @c3024 Eep! 4 days overdue now. Issues have feelings too...

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-28] Web - Pay someone-Wallet page displayed in central pane instead of 1:1 chat after validating account #52456

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

29 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-11-28] Web - Pay someone-Wallet page displayed in central pane instead of 1:1 chat after validating account #52456

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 13, 2024

melvin-bot commented on Nov 13, 2024

melvin-bot commented on Nov 13, 2024

github-actions commented on Nov 13, 2024

IuliiaHerets commented on Nov 13, 2024

Nodebrute commented on Nov 13, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

29 remaining items

melvin-bot commented on Dec 2, 2024

c3024 commented on Dec 2, 2024

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

melvin-bot commented on Dec 4, 2024

muttmuure commented on Dec 5, 2024

c3024 commented on Dec 5, 2024

sonialiap commented on Dec 5, 2024

c3024 commented on Dec 6, 2024

melvin-bot commented on Dec 9, 2024

JmillsExpensify commented on Dec 9, 2024

melvin-bot commented on Dec 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions