[HOLD for payment 2025-01-15] [$250] There is no way to identify the primary workspace, making it appear essentially random

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): ts_external_expensify_retain

Action Performed:

Prerequisite: User have multiple workspaces

1. Go to staging.new.expensify.com
2. Click Settings > Workspaces

Expected Result:

Add some indicator in the workspace list as to which is primary
Add some ability to make a given workspace primary

Actual Result:

There's no way to know which workspace is primary, nor control it, so it's essentially random.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857052923539231166
• Upwork Job ID: 1857052923539231166
• Last Price Increase: 2024-11-21
• Automatic offers:
• Krishna2323 | Contributor | 105026569

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

There is no way to identify the primary workspace, making it appear essentially random

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?


• We can add one more badge to indicate the active policy.
• We can get activePolicyID from useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID); and use the condition activePolicyID === policyID to display the badge.
• We might need to create translations for the badge text and we can discuss the icon in the PR.
  

  App/src/pages/workspace/WorkspacesListRow.tsx

  Lines 142 to 151 in f906450

  	{!!isJoinRequestPending && (
  	<View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, styles.justifyContentEnd]}>
  	<Badge
  	text={translate('workspace.common.requested')}
  	textStyles={styles.textStrong}
  	badgeStyles={[styles.alignSelfCenter, styles.badgeBordered]}
  	icon={Expensicons.Hourglass}
  	/>
  	</View>
  	)}

• Then we can add an option to make a policy default in WorkspacesListPage and create util function for updating the onyx values (NVP_ACTIVE_POLICY_ID) and making the api call. We might only want to show the Make default option only if isOwner is true, we can use the condition if (isOwner) { or we can add the option without any condition.
  

  App/src/pages/workspace/WorkspacesListPage.tsx

  Lines 156 to 167 in f906450

  	if (isOwner) {
  	threeDotsMenuItems.push({
  	icon: Expensicons.Trashcan,
  	text: translate('workspace.common.delete'),
  	onSelected: () => {
  	setPolicyIDToDelete(item.policyID ?? '-1');
  	setPolicyNameToDelete(item.title);
  	setIsDeleteModalOpen(true);
  	},
  	shouldCallAfterModalHide: true,
  	});
  	}

• We can use theme.success for badge border.

Note

I don't think there is an api endpoint used in new dot to update the NVP_ACTIVE_POLICY_ID, so we need to add the api endpoint and the types for that.

What alternative solutions did you explore? (Optional)

Result

[melvin-bot]

Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.