Repository navigation
[HOLD for payment 2024-12-05] Verify account - No right side window animation when 2FA setup is dismissed #52339
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): wjiojdoowjojwodj@gmail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Log in with a new Gmail account.
- Go to Settings > Security > Two-factor authentication.
- Dismiss the RHP.
Expected Result:
There will be animation when Validate your account RHP from 2FA setup is dismissed.
Actual Result:
There is no animation (side window doesn't slide close like on other pages) when Validate your account RHP from 2FA setup is dismissed.
Workaround:
Гтлтщцт
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6661746_1731353635975.20241112_032620.mp4
Issue Owner
Current Issue Owner: @ChristinadobrzynMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Nov 11, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 11, 2024
Triggered auto assignment to @deetergp (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 11, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
deetergp commentedon Nov 11, 2024
I don't think this is a blocker since it is a new feature and isn't breaking any existing functionality.
45 remaining items
hungvu193 commentedon Dec 4, 2024
@mountiny I'm not sure if I'm eligible to be paid for this issue. During PR process we realized this issue also happened every where on mWeb Chrome and we fixed it as well.
mountiny commentedon Dec 4, 2024
@hungvu193 to confirm, you have been a c+ on the offending PR, right? then I think we should not really issue a payment here. Or am I misunderstanding your question?
melvin-bot commentedon Dec 5, 2024
Payment Summary
Upwork Job
BugZero Checklist (@Christinadobrzyn)
hungvu193 commentedon Dec 5, 2024
Ah I mean, while working on the PR, we found out the the right side animation didn't work on mWeb (which is not a regression from the PR that I reviewed) and we fixed it as well.
mountiny commentedon Dec 5, 2024
ok sounds like $250 to @hungvu193 too
Christinadobrzyn commentedon Dec 5, 2024
Regression test - https://github.com/Expensify/Expensify/issues/450960
Payment summary here - #52339 (comment)
Feel free to submit a NewDot payment request @hungvu193 and @bernhardoj
bernhardoj commentedon Dec 6, 2024
Requested in ND.
Christinadobrzyn commentedon Dec 6, 2024
DMd @hungvu193 to request payment in ND. Going to close this out.
hungvu193 commentedon Dec 6, 2024
Thanks for reminding me. I've just requested on ND
JmillsExpensify commentedon Dec 9, 2024
$250 approved for @bernhardoj via the summary
garrettmknight commentedon Dec 12, 2024
$250 approved for @hungvu193