Unable to see 'Review Duplicates' button while offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #48958
Email or phone of affected tester (no customers): applausetester+bm211@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Workspace A has tax rates, categories, and tags.
2. Workspace B does not have taxes, categories, and tags feature enabled.
3. Open the chat for Workspace A.
4. Submit an expense in Workspace A with a tax rate, category, and tag (us5. e the same amount and merchant).
5. Submit another expense in Workspace A with all fields left empty (defaults).
6. Open the chat for Workspace B.
7. Submit an expense in Workspace B with the same amount and merchant as the previous entries.
8. Open the transaction thread for the expense submitted in Workspace B.

Expected Result:

Review Duplicates should appear

Actual Result:

Review Duplicates doesn't appear.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6657937_1731003396541.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[brunovjk]

I can Review Duplicate without any problems, both in the latest main and in production, the button is always there:

latest `main`

Screen.Recording.2024-11-07.at.15.54.38.mov

@IuliiaHerets Could it be that the account has no "beta" permissions? The same steps for a new account, the button really doesn't appear:

New account, without permissions

Screen.Recording.2024-11-07.at.15.56.53.mov

cc: @pecanoro

[IuliiaHerets]

@brunovjk Can you check in offline mode? Issue happens only in offline

[brunovjk]

Thank you for pointing that out, @Iuliia. Indeed, I retested and confirmed that when following all steps while offline, the "Review Duplicates" alert does not appear as expected.

latest `main`

Screen.Recording.2024-11-07.at.16.22.25.mov

I think this is because the server is required to check for duplicate expenses. It seems our original PR tests should either not have included offline steps or should have outlined them differently. @Kristina2323 @pecanoro Thoughts?

[pecanoro]

@brunovjk The button didn't show before the changes either way, right? It seems this has never been an option so let's just skip offline tests since they don't apply

[brunovjk]

The button didn't show before the changes either way, right? It seems this has never been an option so let's just skip offline tests since they don't apply

Yes. Great then.

#48958 - Failing with #52210

Minor, not a blocker. Checking off.

@pecanoro do you think we need to change the Steps for Testing the PR (remove offline)? I wonder if the "Online QA Steps" passed successfully. Thank you.

[pecanoro]

Yeah, we need to do so, @Krishna2323 could you update the offline steps?

[Krishna2323]

I have updated the offline tests.

[melvin-bot]

@pecanoro, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[pecanoro]

Perfect, closing this one then