[HOLD for payment 2024-11-18] [$125] Expensify Card - Back button on issue card page returns to Bank account verified page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.56-3
Reproducible in staging?: Y
Reproducible in production?: N/A Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card
3. Click Issue new card
4. Add a bank account
5. Dismiss the RHP
6. Click Issue new account
7. Select the added bank account
8. On Bank account verified page, click Got it
9. On Issue card page, click RHP back button

Expected Result:

The RHP will be dismissed

Actual Result:

App returns to Bank account verified page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6652488_1730477794594.bandicam_2024-11-02_00-05-53-300.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @OfstadC

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853850206557900537
• Upwork Job ID: 1853850206557900537
• Last Price Increase: 2024-11-05
• Automatic offers:
• Nodebrute | Contributor | 104755066
• rayane-djouah | Contributor | 104792968

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button on issue card page returns to Bank account verified page

What is the root cause of that problem?

When user press Got it we simply navigate to next page rather then dismissing the current modal

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

Line 154 in b9ec75a

onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID))}

What changes do you think we should make in order to solve the problem?

We should also dismiss the modal before navigating here. We can do something like this

   onPress={() => {
                                Navigation.dismissModal();
                                Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID)); 
                            }}

It's a similar approach that we also use in other places

What alternative solutions did you explore? (Optional)

We can also use goBack() before navigating to WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW

[thienlnam]

I'm not sure if this is actually a bug or not - adding external so we can get a BZ assigned to determine whether we should fix this or not

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)