[HOLD for payment 2024-11-21] Re-direct to Classic when creating expenses for non-migrated users

@puneetlath

There are scenarios where users who have not yet had their group workspaces NewDot-enabled in NewDot. In those scenarios, things can get confusing if they try to create expenses.

To address this, let's block them from Creating, Tracking, Submitting expenses from NewDot if they are:

on at least one group policy
none of the group policies they are a member of have isPolicyExpenseChatEnabled=true

We should do this by showing a modal when they tap/click any of these options, which re-directs them back to OldDot.

Issue Owner

Current Issue Owner: @puneetlath

@puneetlath

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@dubielzyk-expensify

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@dubielzyk-expensify

@dubielzyk-expensify can you help with some mocks of what that re-direct to Classic modal should look like?

@jamesdeanexpensify

Yes sir. Think we need some @jamesdeanexpensify magic to make the copy more crisp (he's back on Monday I believe).

Mocks

cc @Expensify/design for vizzzibilities

Proposal

Please re-state the problem that we are trying to solve in this issue.

Re-direct to Classic when creating expenses for non-migrated users

What is the root cause of that problem?

It is new feature.

What changes do you think we should make in order to solve the problem?

In FloatingActionButtonAndPopover, add a new modal:

            <ConfirmModal
                prompt={'Due to how your workspace is set up, submitting and tracking expenses has been disabled for now. Please go to Expensify Classic to add an expense.'}
                isVisible={modalVisible}
                onConfirm={() => {
                    setModalVisible(false);
                    Link.openOldDotLink(CONST.OLDDOT_URLS.INBOX);
                }}
                onCancel={() => setModalVisible(false)}
                title={'Your workspace is not ready for New Expensify'}
                confirmText={translate('exitSurvey.goToExpensifyClassic')}
                cancelText={translate('common.cancel')}
            />

Then, introduce a new variable to check whether we should redirect user to OD:

    const [modalVisible, setModalVisible] = useState(false);
    const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY);
    const shouldRedirectToOD = useMemo(() => {
        const groupPolicies = Object.values(policies ?? {}).filter((policy) => ReportUtils.isGroupPolicy(policy));
        if (groupPolicies.length === 0) {
            return false;
        }
        return !groupPolicies.some((groupPolicy) => groupPolicy?.isPolicyExpenseChatEnabled);
    }, [policies]);

Finally, update the callback function when clicking on Submit expense option:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Line 404 in 6463c2b

interceptAnonymousUser(() =>

                    interceptAnonymousUser(() => {
                        if (shouldRedirectToOD) {
                            setModalVisible(true);
                            return;
                        }
                        IOU.startMoneyRequest(
                            CONST.IOU.TYPE.SUBMIT,
                            // When starting to create an expense from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
                            // for all of the routes in the creation flow.
                            ReportUtils.generateReportID(),
                        );
                    }),

The similar should be applied with Track expense and Send invoice options.

What alternative solutions did you explore? (Optional)

@ishpaul777

Payment Summary

Upwork Job

ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@suneox

@suneox can you complete the checklist here?

@suneox

BugZero Checklist

[@suneox] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Proposal

Step 1: Create a control workspace on a new account in OldDot.
Step 2: Sign in to the same account on NewDot.
Step 3: Click on the FAB -> Create/Send/Track Expense.
Step 4: Verify that a “Coming Soon” modal is displayed.

Do we agree 👍 or 👎

@puneetlath

@puneetlath, @suneox, @ishpaul777, @dubielzyk-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@ishpaul777

@ishpaul777 offer here: https://www.upwork.com/nx/wm/offer/105064871
@suneox offer here: https://www.upwork.com/nx/wm/offer/105064898

Can y'all ping me here when you've accepted?

Regression test GH: https://github.com/Expensify/Expensify/issues/447666

@puneetlath

Thank you! I have accepted the offer @puneetlath

@ishpaul777

@ishpaul777 has been paid.

I've accepted the offer. Thank you

Everyone has been paid now. Thanks everyone!

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-21] Re-direct to Classic when creating expenses for non-migrated users #51804

Mocks

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

46 remaining items

Payment Summary

BugZero Checklist (@puneetlath)

BugZero Checklist

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-11-21] Re-direct to Classic when creating expenses for non-migrated users #51804

Description

Activity

melvin-bot commented on Oct 31, 2024

melvin-bot commented on Oct 31, 2024

melvin-bot commented on Oct 31, 2024

puneetlath commented on Oct 31, 2024

dubielzyk-expensify commented on Nov 1, 2024

Mocks

daledah commented on Nov 1, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

46 remaining items

melvin-bot commented on Nov 21, 2024

Payment Summary

BugZero Checklist (@puneetlath)

puneetlath commented on Nov 21, 2024

suneox commented on Nov 21, 2024

BugZero Checklist

Regression Test Proposal

melvin-bot commented on Nov 25, 2024

puneetlath commented on Nov 25, 2024

ishpaul777 commented on Nov 25, 2024

puneetlath commented on Nov 25, 2024

suneox commented on Nov 25, 2024

puneetlath commented on Nov 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions