Repository navigation
[C+ Checklist Needs Completion] [$125] mWeb - Chat - Part of the #Admins welcome message is still in english when changing language #51577
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.54-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5131860&group_by=cases:section_id&group_order=asc&group_id=229070
Issue reported by: Applause - Internal Team
Action Performed:
- Open the staging.new.expensify.com website
- Tap on "Settings" on the bottom of the screen
- Tap on "Preferences"
- Tap on "Language" and select "Spanish"
- Tap on the arrow on the top left corner
- Tap on "Inbox" and enter the "#Admins" chat
- Verify that the welcome message is fully displayed in spanish now
Expected Result:
The welcome message in "#Admins" chat should be displayed completely in spanish when changing language
Actual Result:
"Use it to chat about workspace setup and more" in the "#Admins" chat welcome message, is still displayed in english when changing language
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6647727_1730068811701.Welcome.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021851377431726711266
- Upwork Job ID: 1851377431726711266
- Last Price Increase: 2024-10-29
- Automatic offers:
- Krishna2323 | Contributor | 104762311
Issue Owner
Current Issue Owner: @greg-schroederMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Oct 28, 2024
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Oct 28, 2024
@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Krishna2323 commentedon Oct 28, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb - Chat - Part of the #Admins welcome message is still in english when changing language
What is the root cause of that problem?
es.tsfile.App/src/languages/es.ts
Line 660 in 9f97734
What changes do you think we should make in order to solve the problem?
Úsalo para hablar sobre la configuración del espacio de trabajo y más., we can confirm it on slack.What alternative solutions did you explore? (Optional)
Result
[-]mWeb - Chat - Part of the #Admins welcome message is still in english when changing language[/-][+][$125] mWeb - Chat - Part of the #Admins welcome message is still in english when changing language[/+]melvin-bot commentedon Oct 29, 2024
melvin-bot commentedon Oct 29, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021851377431726711266
melvin-bot commentedon Oct 29, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)greg-schroeder commentedon Nov 1, 2024
Awaiting proposal review
23 remaining items
melvin-bot commentedon Nov 26, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 26, 2024
@rushatgabhane @greg-schroeder @rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
greg-schroeder commentedon Dec 3, 2024
Payment summary:
Contributor: @Krishna2323 - $125 - Paid via Upwork
C+: @rushatgabhane - $125 - NewDot manual request
greg-schroeder commentedon Dec 3, 2024
All that's left is the C+ checklist @rushatgabhane
[-][HOLD for payment 2024-12-03] [$125] mWeb - Chat - Part of the #Admins welcome message is still in english when changing language[/-][+][C+ Checklist Needs Completion] [$125] mWeb - Chat - Part of the #Admins welcome message is still in english when changing language[/+]greg-schroeder commentedon Dec 6, 2024
Bump @rushatgabhane <3
rushatgabhane commentedon Dec 6, 2024
oopsie doosie
rushatgabhane commentedon Dec 6, 2024
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49919/files#r1873760222
If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No we have checklist for this.
If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. No
garrettmknight commentedon Dec 12, 2024
$125 approved for @rushatgabhane