Search - Tooltip is not displayed on the new Saved search indicating the name can be edited

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3284916
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to the Search page
2. Click on the filter icon
3. Set a filter for the category “Advertising”
4. Click on Save > Save Search button

Expected Result:

A new “Saved” section is displayed on the Search page navigation.
A tooltip is displayed on the new Saved search indicating the name can be edited

Actual Result:

A tooltip is not displayed on the new Saved search indicating the name can be edited

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6646602_1729941344494.no_tooltip.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-control

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip is not displayed on the saved search.

What is the root cause of that problem?

we are only showing the tooltip once, based on this comment and code:

App/src/pages/Search/AdvancedSearchFilters.tsx

Lines 290 to 293 in 652d2ff

	// We only want to show the tooltip once, the NVP will not be set if the user has not saved a search yet
	if (!savedSearches) {
	SearchActions.showSavedSearchRenameTooltip();
	}

What changes do you think we should make in order to solve the problem?

if we want to show the tooltip each time a user save the search , we can remove the condition, and directly write:
SearchActions.showSavedSearchRenameTooltip();

Screen.20Recording.202024-10-27.20at.201.mp4

[Christinadobrzyn]

Gonna test this tomorrow when I'm back from ooo

[FitseTLT]

Looks like intentional

App/src/pages/Search/AdvancedSearchFilters.tsx

Lines 290 to 293 in 652d2ff

	// We only want to show the tooltip once, the NVP will not be set if the user has not saved a search yet
	if (!savedSearches) {
	SearchActions.showSavedSearchRenameTooltip();
	}

[Christinadobrzyn]

I'm not sure I understand the problem, the video doesn't match the steps in the OP. What are we trying to solve? Where is the 'tooltip' - do you mean the hamburger with the option to Rename?

https://expensify.slack.com/archives/C9YU7BX5M/p1730168405943419

[izarutskaya]

We refer to #49473 and expect to see this tooltip

Let me know if I can help something else

[Christinadobrzyn]

Ah okay, I don't see that is possible in https://staging.new.expensify.com/ either.

I'll ask one more question in the QA chat, and then I'll reach out to the team to see if we want this.

[izarutskaya]

We tested step by step in TR and step 8 says that Verify a tooltip is displayed on the new Saved search indicating the name can be edited

Screenshot with tooltip from this PR and you will see link with PR at the bottom of the page in "Comments or Known issue".

Check please TR link. Thanks

[Christinadobrzyn]

Amazing! Thank you for all the information @izarutskaya!

@lanitochka17 and @luacmartins since you were part of this issue

Can you confirm that we want the tooltip to show on a saved search? From what I can tell, the tooltip doesn't show with any desktop version so I just want to make sure we want it.

Here's an image of the tooltip that we're referring to

#51531 (comment)

Thanks!

[luacmartins]

@izarutskaya the tooltip should only be shown the first time ever you save a search. So if you are testing on an existing account that has already saved a search in the past (even though all saved searches are deleted), we should NOT show the tooltip again. Hope that clarifies things.