Skip to content

[Awaiting checklist] [$250] Contact method - Keyboard not opened when navigating to enter magic code step #51279

Closed
Closed
[Awaiting checklist] [$250] Contact method - Keyboard not opened when navigating to enter magic code step#51279
Assignees
cead22twisterdotcomOllywsbernhardoj
Labels
BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Description

@IuliiaHerets
IuliiaHerets
opened on Oct 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.52.1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #49445
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the app and log in
  2. Navigate to the account settings > Profile > Contact method
  3. Tap the New contact method button
  4. Enter an email that will be used as a secondary login
  5. Proceed to the magic code step

Expected Result:

The keyboard is opened automatically

Actual Result:

The keyboard is not opened automatically

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6642245_1729612995396.video_2024-10-22_12-03-06.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848790071589041805
  • Upwork Job ID: 1848790071589041805
  • Last Price Increase: 2024-10-22
Issue OwnerCurrent Issue Owner: @Ollyws

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 22, 2024
  2. melvin-bot
    assigned
    cead22
    and
    twisterdotcom
    on Oct 22, 2024

  3. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botbot
    on Oct 22, 2024 – with Melvin Bot

    Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botbot
    on Oct 22, 2024 – with Melvin Bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botbot
    on Oct 22, 2024 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  6. melvin-bot
    added
    DailyKSv2
    on Oct 22, 2024
  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Oct 22, 2024

  8. github-actions commented on Oct 22, 2024

    @github-actions
    github-actionsbot
    on Oct 22, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. cead22 commented on Oct 22, 2024

    @cead22
    cead22
    on Oct 22, 2024
    Contributor

    I couldn't reproduce on iOS native, but regardless, this doesn't need to be a blocker

  10. cead22
    removed
    HourlyKSv2
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 22, 2024

  11. 21 remaining items

  12. melvin-bot
    changed the title [-][$250] Contact method - Keyboard not opened when navigating to enter magic code step[/-] [+][HOLD for payment 2024-11-22] [$250] Contact method - Keyboard not opened when navigating to enter magic code step[/+] on Nov 15, 2024

  13. melvin-bot commented on Nov 15, 2024

    @melvin-bot
    melvin-botbot
    on Nov 15, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot
    removed
    ReviewingHas a PR in review
    on Nov 15, 2024

  15. melvin-bot commented on Nov 15, 2024

    @melvin-bot
    melvin-botbot
    on Nov 15, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-22. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Ollyws requires payment through NewDot Manual Requests
    • @bernhardoj requires payment through NewDot Manual Requests

  16. melvin-bot commented on Nov 15, 2024

    @melvin-bot
    melvin-botbot
    on Nov 15, 2024 – with Melvin Bot

    @Ollyws @twisterdotcom @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. twisterdotcom commented on Nov 22, 2024

    @twisterdotcom
    twisterdotcom
    on Nov 22, 2024
    Contributor

    Payment Summary:

    • @Ollyws paid $250 via NewDot Manual Request
    • @bernhardoj paid $250 via NewDot Manual Request

  18. twisterdotcom commented on Nov 22, 2024

    @twisterdotcom
    twisterdotcom
    on Nov 22, 2024
    Contributor

    Waiting on the checklist now @Ollyws.

  19. twisterdotcom
    removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Nov 22, 2024
  20. twisterdotcom
    changed the title [-][HOLD for payment 2024-11-22] [$250] Contact method - Keyboard not opened when navigating to enter magic code step[/-] [+][Awaiting checklist] [$250] Contact method - Keyboard not opened when navigating to enter magic code step[/+] on Nov 22, 2024

  21. bernhardoj commented on Nov 22, 2024

    @bernhardoj
    bernhardoj
    on Nov 22, 2024
    Contributor

    Requested in ND.

  22. JmillsExpensify commented on Nov 25, 2024

    @JmillsExpensify
    JmillsExpensify
    on Nov 25, 2024
    Contributor

    $250 approved for @bernhardoj

  23. Ollyws commented on Nov 25, 2024

    @Ollyws
    Ollyws
    on Nov 25, 2024
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/49445/files#r1857315081

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Open settings > Profile > Contact method
2. Tap the New contact method button
3. Enter any email that will be used as a secondary login
4. Press on anywhere to close the keyboard
5. Proceed to the magic code step
6. Verify the magic code input is focused and a keyboard is shown (mobile)

    Do we agree 👍 or 👎

  24. Ollyws commented on Nov 25, 2024

    @Ollyws
    Ollyws
    on Nov 25, 2024
    Contributor

    Requested in ND.

  25. twisterdotcom
    closed this as completedon Nov 26, 2024

  26. garrettmknight commented on Nov 26, 2024

    @garrettmknight
    garrettmknight
    on Nov 26, 2024
    Contributor

    $250 approved for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions