Repository navigation
[HOLD for payment 2024-11-13] [$250] Copilot - Nothing happens when clicking Add copilot after returning from magic code page #51273
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to Account settings > Security.
- Click Add copilot.
- Select a user > Next.
- Select an access level > Next.
- Click Add copilot.
- Click RHP back button.
- Click Add copilot.
Expected Result:
App will proceed to magic code page.
Actual Result:
Nothing happens when clicking Add copilot after returning from magic code page.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6642186_1729610589423.20241022_232027.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021848771830019077606
- Upwork Job ID: 1848771830019077606
- Last Price Increase: 2024-10-22
- Automatic offers:
- cretadn22 | Contributor | 104557922
Activity
melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 22, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Copilot - Nothing happens when clicking Add copilot after returning from magic code page[/-][+][$250] Copilot - Nothing happens when clicking Add copilot after returning from magic code page[/+]18 remaining items
[-][$250] Copilot - Nothing happens when clicking Add copilot after returning from magic code page[/-][+][HOLD for payment 2024-11-13] [$250] Copilot - Nothing happens when clicking Add copilot after returning from magic code page[/+]melvin-bot commentedon Nov 6, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 6, 2024
@jayeshmangwani @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jayeshmangwani commentedon Nov 13, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Refactor: reuse ValidateCodeActionModal #49445 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
IMO, A dedicated regression test isn't necessary here. If this issue recurs, it should be easily detectable during the usual add copilot flow.
isabelastisser commentedon Nov 13, 2024
Payment summary:
@jayeshmangwani - $250 for C+ review. Requires payment through NewDot Manual Requests
PENDING@cretadn22 - Contributor - requires payment in Upwork.
PAID. automatic offergarrettmknight commentedon Nov 26, 2024
$250 approved for @jayeshmangwani