Repository navigation
[HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Copilot - Nothing happens when clicking on the grayed out user when magic code is incorrect #51266
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.comLogs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to Account settings > Security.
- Click Add copilot.
- Select a user > Next.
- Select an access level > Next.
- Click Add copilot.
- Enter wrong magic code.
- Click outside the RHP twice to dismiss it.
- Click on the grayed out user under Copilot: Delegated access section.
Expected Result:
Clicking on the grayed out user will open up magic code RHP (production behavior).
Actual Result:
Nothing happens when clicking on the grayed out user when magic code is incorrect.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @bondydaa (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 22, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
bondydaa commentedon Oct 22, 2024
testing reverting this locally as i'm suspicious of it #49445
bondydaa commentedon Oct 22, 2024
yep testing locally I'm fairly certain #49445 is the problem
cc @mountiny @getusha @hungvu193
luacmartins commentedon Oct 22, 2024
We might add a fix for this in this PR
13 remaining items
[-]Copilot - Nothing happens when clicking on the grayed out user when magic code is incorrect[/-][+][HOLD for payment 2024-10-30] Copilot - Nothing happens when clicking on the grayed out user when magic code is incorrect[/+]melvin-bot commentedon Oct 23, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-30. 🎊
melvin-bot commentedon Oct 23, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
tgolen commentedon Oct 23, 2024
Reopening for @bondydaa and @sakluger to finish the checklist
bondydaa commentedon Oct 24, 2024
i think we followed those steps properly, i don't think we need a regression test or rather we already have one since this was caught during testing so i think we're good here?
[-][HOLD for payment 2024-10-30] Copilot - Nothing happens when clicking on the grayed out user when magic code is incorrect[/-][+][HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Copilot - Nothing happens when clicking on the grayed out user when magic code is incorrect[/+]melvin-bot commentedon Oct 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-01. 🎊
melvin-bot commentedon Oct 25, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: