Android - Onboarding -Onboarding modal is missing

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: .9.0.51
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #50979
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the Hybrid app.
2. Log in with new gmail account
3. Close the app
4. Enable the option "Try new Expensify"
5. Reopen the app and log in if needed
6. Tap on the "Try new Expensify" option.

Expected Result:

The Onboarding modal is displayed

Actual Result:

A Welcome message is displayed but the Onboarding modal is missing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6641429_1729546321992.50979-Android.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[andriivitiv]

I think it's the expected behavior that the onboarding modal is not shown for OldDot accounts. This will require a BE fix if we want to change this.

App/src/libs/onboardingSelectors.ts

Lines 11 to 18 in d3db2a1

	function hasCompletedGuidedSetupFlowSelector(onboarding: OnyxValue<typeof ONYXKEYS.NVP_ONBOARDING>): boolean | undefined {
	// Onboarding is an array for old accounts and accounts created from OldDot
	if (Array.isArray(onboarding)) {
	return true;
	}
	return onboarding?.hasCompletedGuidedSetupFlow;
	}

[abekkala]

@vitHoracek based on this Slack conversation

I think this reported issue is not actually an issue, correct? it would be expected that an onboarding modal is not shown in this scenario? would you be able to confirm and double-check me on this?

[mountiny]

Correct i believe this is expected. We show the welcome banner for user who migrated in this case

[melvin-bot]

@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

[abekkala]

hmm, thought I closed this on Monday - 🤷🏼‍♀️
based on the expectation - this is not an issue