Skip to content

[HOLD for payment 2024-11-29] [HOLD for payment 2024-11-20] [HOLD for payment 2024-11-13] [$250] Add a step that collects the magic code when adding a VBBA #51166

Closed
Closed
[HOLD for payment 2024-11-29] [HOLD for payment 2024-11-20] [HOLD for payment 2024-11-13] [$250] Add a step that collects the magic code when adding a VBBA#51166
Assignees
garrettmknighthungvu193mountinyshahinyan11getusha
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Description

@trjExpensify
trjExpensify
opened on Oct 21, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Applicable on all platforms
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C07HPDRELLD/p1729255848407089?thread_ts=1729042472.964519&cid=C07HPDRELLD

Action Performed:

  1. Go to expensify.com > sign-up > choose "1-9" to be redirected to NewDot
  2. Complete the onboarding modal steps to have a workspace created.
  3. Go to Settings > Workspaces > Click into the workspace created
  4. Go to More features > Enable workflows
  5. Go to Workflows > Make or track payments > Connect bank account

Expected Result:

This is a feature request.

  1. Neither the "Connect online with Plaid" or "Connect manually" option rows are greyed out
  2. There isn't a "Hold up! We need you to..." error message.
  3. When clicking either of the option rows in 1 above, we send a magic code email to the user, and show this validate your account page to collect it:
image

Actual Result:

  1. Both option rows are greyed out
  2. There's an error message on the page which we've since deprecated elsewhere in favour of a better experience to fire off and collect a magic code.
image

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

In-line above.

View all open jobs on GitHub

CC: @shawnborton @mountiny

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848301297798537201
  • Upwork Job ID: 1848301297798537201
  • Last Price Increase: 2024-10-21
  • Automatic offers:
    • shahinyan11 | Contributor | 104639697
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. trjExpensify
    added
    DailyKSv2
    NewFeatureSomething to build that is a new item.
    on Oct 21, 2024
  2. trjExpensify
    added this to [#whatsnext] #converton Oct 21, 2024
  3. melvin-bot
    assigned
    abekkala
    on Oct 21, 2024

  4. melvin-bot commented on Oct 21, 2024

    @melvin-bot
    melvin-botbot
    on Oct 21, 2024 – with Melvin Bot

    Triggered auto assignment to @abekkala (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  5. melvin-bot
    added
    WeeklyKSv2
    and removed
    DailyKSv2
    on Oct 21, 2024
  6. trjExpensify
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 21, 2024

  7. melvin-bot commented on Oct 21, 2024

    @melvin-bot
    melvin-botbot
    on Oct 21, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~021848301297798537201

  8. melvin-bot
    changed the title [-]Add a step that collects the magic code when adding a VBBA[/-] [+][$250] Add a step that collects the magic code when adding a VBBA[/+] on Oct 21, 2024
  9. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 21, 2024
  10. trjExpensify
    moved this to Todo in [#whatsnext] #converton Oct 21, 2024
  11. melvin-bot
    assigned
    Pujan92
    on Oct 21, 2024

  12. melvin-bot commented on Oct 21, 2024

    @melvin-bot
    melvin-botbot
    on Oct 21, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

  13. melvin-bot
    added
    DailyKSv2
    on Oct 21, 2024

  14. 108 remaining items

  15. getusha commented on Dec 4, 2024

    @getusha
    getusha
    on Dec 4, 2024
    Contributor

    No, I do not think we have a test for this specific flow @hungvu193 @getusha could you complete the checklist here and propose a test to add please? thanks!

    On it, thanks

  16. hungvu193 commented on Dec 9, 2024

    @hungvu193
    hungvu193
    on Dec 9, 2024
    Contributor

    What's the payment summary for this one? I think we created 3 PRs for this issue.

  17. mountiny commented on Dec 9, 2024

    @mountiny
    mountiny
    on Dec 9, 2024
    Contributor

    @hungvu193 can you please list them out for simplicity?

    @getusha can you then complete the regression tests for these prs please?

  18. hungvu193 commented on Dec 9, 2024

    @hungvu193
    hungvu193
    on Dec 9, 2024
    Contributor

    @hungvu193 can you please list them out for simplicity?

    Sure, here's the list:
    #51882
    #51718
    #52356

  19. getusha commented on Dec 9, 2024

    @getusha
    getusha
    on Dec 9, 2024
    Contributor

    Regression Test Proposal

    Invoices

    1. Sign in with an email that haven't been used to create an account and complete the onboarding
    2. Create a new workspace
    3. Go to More features > Enable workflows
    4. Go to Invoices page and press Add bank account.
    5. Verify that you're navigated to VerifyAccountPage and received a magic code to your email
    6. Enter the code from the email
    7. Verify you can continue the VBBA flow.

    Workflows

    1. Sign in with an email that haven't been used to create an account and complete the onboarding
    2. Create a new workspace
    3. Go to More features > Enable workflows
    4. Go to Workflows > Make or track payments > Connect bank account
    5. Connect via Plaid
    6. Verify that you're navigated to Validate your account page and received a magic code to your email
    7. Navigate back and press Connect manually
    8. Verify that you're navigated to Validate your account page and received a magic code to your email
    9. Enter the code from the email
    10. Verify you can continue the VBBA flow.

    2FA Authentication

    1. Sign in with an email that haven't been used to create an account and complete the onboarding
    2. Go to Settings > Security > Two-factor authentication
    3. Verify that you're navigated to Validate your account page and received a magic code to your email
    4. Enter the code from the email
    5. Verify that you're navigated to Two-factor authentication page

    Do we agree 👍 or 👎

  20. mountiny commented on Dec 9, 2024

    @mountiny
    mountiny
    on Dec 9, 2024
    Contributor

    @hungvu193 $750
    @shahinyan11 $500
    @getusha $250

    is the summary

  21. melvin-bot
    added
    Overdue
    on Dec 11, 2024
  22. garrettmknight
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Dec 11, 2024
  23. melvin-bot
    removed
    Overdue
    on Dec 11, 2024

  24. garrettmknight commented on Dec 12, 2024

    @garrettmknight
    garrettmknight
    on Dec 12, 2024
    Contributor

    $750 approved for @hungvu193

  25. garrettmknight commented on Dec 13, 2024

    @garrettmknight
    garrettmknight
    on Dec 13, 2024
    Contributor

    @getusha request when you're ready.

  26. garrettmknight
    closed this as completedon Dec 13, 2024
  27. github-project-automation
    moved this from Todo to Done in [#whatsnext] #converton Dec 13, 2024

  28. garrettmknight commented on Jan 29, 2025

    @garrettmknight
    garrettmknight
    on Jan 29, 2025
    Contributor

    $250 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions