Skip to content

[$250] [HOLD for payment 2024-11-01] Search - Down caret icon and search icon are close to each other #51077

Closed
Closed
[$250] [HOLD for payment 2024-11-01] Search - Down caret icon and search icon are close to each other#51077
Assignees
KiculuacmartinsmallenexpensifyMonilBhavsarrayane-d
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Oct 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.50-4
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+zm37@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch New Expensify app.
  2. Go to FAB > Start chat.
  3. Select a user with long name.
  4. Submit an expense to the user.
  5. Make sure that user name and expense amount are long enough to reach the search icon on the expense report header.
  6. Go to expense report.

Expected Result:

There will be spacing between the down caret and search icon on the expense report header.

Actual Result:

The down caret and search icon are very close to each other.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6638169_1729198209607!IMG_5549

Bug6638169_1729198128310.ScreenRecording_10-18-2024_04-42-44_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021853588853114817182
  • Upwork Job ID: 1853588853114817182
  • Last Price Increase: 2024-11-05

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 18, 2024
  2. melvin-bot
    assigned
    mallenexpensify
    and
    MonilBhavsar
    on Oct 18, 2024

  3. melvin-bot commented on Oct 18, 2024

    @melvin-bot
    melvin-botBot
    on Oct 18, 2024 – with Melvin Bot

    Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 18, 2024

    @melvin-bot
    melvin-botBot
    on Oct 18, 2024 – with Melvin Bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Oct 18, 2024

    @melvin-bot
    melvin-botBot
    on Oct 18, 2024 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  6. melvin-bot
    added
    DailyKSv2
    on Oct 18, 2024
  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Oct 18, 2024

  8. github-actions commented on Oct 18, 2024

    @github-actions
    github-actionsBot
    on Oct 18, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. SzymczakJ commented on Oct 18, 2024

    @SzymczakJ
    SzymczakJ
    on Oct 18, 2024
    Contributor

    This is a small visual bug and I don't think it deserves a Deploy Blocker label. @luacmartins
    I'd like to fix it since I implemented Search 2.4.

  10. MonilBhavsar commented on Oct 18, 2024

    @MonilBhavsar
    MonilBhavsar
    on Oct 18, 2024
    Contributor

    Thank you! Agree, this is not really a blocker.
    I will assign you to this issue

  11. MonilBhavsar
    assigned
    SzymczakJ
    on Oct 18, 2024

  12. 30 remaining items

  13. melvin-bot commented on Nov 5, 2024

    @melvin-bot
    melvin-botBot
    on Nov 5, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~021853588853114817182

  14. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 5, 2024

  15. melvin-bot commented on Nov 5, 2024

    @melvin-bot
    melvin-botBot
    on Nov 5, 2024 – with Melvin Bot

    Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

  16. mallenexpensify commented on Nov 5, 2024

    @mallenexpensify
    mallenexpensify
    on Nov 5, 2024
    Contributor

    @rayane-djouah can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~021853588853114817182

  17. melvin-bot
    removed
    Overdue
    on Nov 5, 2024
  18. mallenexpensify
    removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 5, 2024

  19. incognito-root commented on Nov 5, 2024

    @incognito-root
    incognito-root
    on Nov 5, 2024

    Proposed Solution

    Will implement:

    1. Add appropriate left margin to search icon for consistent spacing between icons
    2. Enable text wrapping for username and amount when they exceed available width

    This will ensure proper spacing while maintaining functionality across all platforms.

    Testing Plan

    Will verify:

    1. Username/amount display:
      • Short text (spacing maintained)
      • Long text (proper wrapping)
    2. All required platforms:
      • iOS/Android (Standalone, HybridApp, mWeb)
      • MacOS (Chrome/Safari, Desktop)
    3. Various screen sizes

    Timeline

    Expected PR in 1 day

  20. MonilBhavsar commented on Nov 5, 2024

    @MonilBhavsar
    MonilBhavsar
    on Nov 5, 2024
    Contributor

    The PR #51081 fixed two bugs and looks like C+ payment was issued in other issue

  21. melvin-bot commented on Nov 5, 2024

    @melvin-bot
    melvin-botBot
    on Nov 5, 2024 – with Melvin Bot

    📣 @incognito-root! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

  22. incognito-root commented on Nov 5, 2024

    @incognito-root
    incognito-root
    on Nov 5, 2024

    Contributor details
    Your Expensify account email: ayaan.work5@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0135886d7cf9ca15ac

  23. melvin-bot commented on Nov 5, 2024

    @melvin-bot
    melvin-botBot
    on Nov 5, 2024 – with Melvin Bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  24. rayane-d commented on Nov 5, 2024

    @rayane-d
    rayane-d
    on Nov 5, 2024
    Contributor

    The PR #51081 fixed two bugs and looks like C+ payment was issued in other issue

    Correct, we can close this issue.

  25. MonilBhavsar commented on Nov 5, 2024

    @MonilBhavsar
    MonilBhavsar
    on Nov 5, 2024
    Contributor

    Thanks!

  26. MonilBhavsar
    closed this as completedon Nov 5, 2024

  27. melvin-bot commented on Nov 5, 2024

    @melvin-bot
    melvin-botBot
    on Nov 5, 2024 – with Melvin Bot

    @luacmartins @mallenexpensify @MonilBhavsar Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions