Skip to content

[BE - Requires Internal Engineer] [$250] Web - Hold - Red dot is lost on held expense when approve pending amount #50823

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.48-2
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #49910
Email or phone of affected tester (no customers): gocemate+workspaceapprover223@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Log in with your Approver account
  2. As employee Go to the room with the two expenses
  3. As employee: hold one expense
  4. Verify there is a red dot on held expense on both sides
  5. As Approver: Approve just the pending amount
  6. As Approver: back to room by click to the header

Expected Result:

Red dot should remain on held report when Approver go back to room

Actual Result:

Red dot disappears from held expense when approve pending amount. It appears only when open the held report again and navigate back to room

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6634951_1728975645603.Recording__4253.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846971961812039151
  • Upwork Job ID: 1846971961812039151
  • Last Price Increase: 2024-11-28
Issue OwnerCurrent Issue Owner: @ntdiary

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 15, 2024
  2. melvin-bot commented on Oct 15, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Oct 15, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. IuliiaHerets commented on Oct 15, 2024

    @IuliiaHerets
    Author

    @zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. zanyrenney commented on Oct 17, 2024

    @zanyrenney
    Contributor

    moving to expense.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 17, 2024
  7. changed the title [-]Web - Hold - Red dot is lost on held expense when approve pending amount[/-] [+][$250] Web - Hold - Red dot is lost on held expense when approve pending amount[/+] on Oct 17, 2024
  8. melvin-bot commented on Oct 17, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 17, 2024
  10. melvin-bot commented on Oct 17, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

  11. Windchasers commented on Oct 18, 2024

    @Windchasers

    Quick question, how do we make a account approver and another employee? Thanks for any help.

  12. 34 remaining items

  13. zanyrenney commented on Nov 29, 2024

    @zanyrenney
    Contributor

    This is on Hold right now and not a priority.

  14. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 4, 2024
  15. garrettmknight commented on Dec 10, 2024

    @garrettmknight
    Contributor

    I actually think this fits in a cohort room since it definitely affects our current cohort. I've moved to #convert since we're pitching Hold to new users.

  16. melvin-bot commented on Dec 13, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @ntdiary, @zanyrenney eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  17. melvin-bot commented on Feb 24, 2025

    @melvin-bot

    @ntdiary, @zanyrenney, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2Not a priority

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions