Skip to content

[Due for payment 2025-06-11] Attendee tracking feature should be a sub-category of 'Rules' #50802

Description

@Julesssss

A part of collect v2

Summary of changes

  • Make attendee tracking a feature that can be enabled/disabled via a toggle
  • Make it restricted to Control policies, by placing the toggle in the Rules section of the workspace editor (which can only be accessed after upgrading)
Image
  • Text to use below the toggle: Track the per-person cost for every expense.

Initial discussion here (internal).

Technical changes

  1. Backend

  2. Frontend

    • Update onyx/Policy.ts with a new prop isAttendeeTrackingEnabled?: boolean
    • Add a toggle to enable or disable Attendee Tracking in the Rules section of the workspace editor, under the existing eReceipts toggle
      • For backwards compatibility, assume the feature is disabled if the prop isAttendeeTrackingEnabled doesn't exist
      • Use the new API command SetPolicyAttendeeTrackingEnabled when toggling the option, with optimistic data
    • Update shouldShowAttendees to only show the attendee selector when the feature is enabled on the selected workspace
  3. Backend (can be done as follow-up updates)

    1. Update commands to throw an error if trying to set/edit attendees on a collect policy expense
    2. Disable the flag after downgrading a policy
    3. Prevent from enabling the feature on collect policies

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions